Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 1019033002: Add an ONC property for the third-party VPN provider extension ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
index d9932356512bb53a5a4e83b66f7a05b9991829d5..e11eb45c12b6b1303c5d0d267349cc69920c0c73 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
@@ -358,6 +358,15 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {
base::StringValue(shill::kProviderOpenVpn));
profile_test->AddService(kUser1ProfilePath, "stub_vpn1");
+ AddService("stub_vpn2", "vpn2", shill::kTypeVPN, shill::kStateOnline);
pneubeck (no reviews) 2015/03/18 19:04:42 maybe don't set every VPN to online, instead at mo
bartfab (slow) 2015/03/18 19:21:16 Done.
pneubeck (no reviews) 2015/03/18 19:35:29 maybe don't set every vpn to Online but at most on
bartfab (slow) 2015/03/18 20:02:14 Eh, done :).
+ service_test_->SetServiceProperty(
+ "stub_vpn2", shill::kProviderTypeProperty,
+ base::StringValue(shill::kProviderThirdPartyVpn));
+ service_test_->SetServiceProperty(
+ "stub_vpn2", shill::kProviderHostProperty,
+ base::StringValue("third_party_provider_extension_id"));
+ profile_test->AddService(kUser1ProfilePath, "stub_vpn2");
+
content::RunAllPendingInMessageLoop();
}

Powered by Google App Engine
This is Rietveld 408576698