Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1019023002: MacViews: Implement non-client frame view (Closed)

Created:
5 years, 9 months ago by Andre
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, mvanland
Base URL:
https://chromium.googlesource.com/chromium/src.git@wrench-menu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Implement non-client frame view Create Mac specific BrowserNonClientFrameViewMac, stop sharing OpaqueBrowserFrameView. Draw the frame using Mac colors, assets, and spacing. Screenshot: https://code.google.com/p/chromium/issues/detail?id=425229#c40 BUG=425229 Committed: https://crrev.com/b7046495e70e7878d9ff20788f0f54a61775cd5d Cr-Commit-Position: refs/heads/master@{#321290}

Patch Set 1 #

Patch Set 2 : Use Yosemite colors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -93 lines) Patch
M chrome/browser/themes/theme_properties.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.h View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 2 chunks +77 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h View 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm View 1 chunk +167 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 3 chunks +6 lines, -80 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Andre
sky@ PTAL.
5 years, 9 months ago (2015-03-18 20:43:22 UTC) #2
sky
LGTM
5 years, 9 months ago (2015-03-18 23:02:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019023002/20001
5 years, 9 months ago (2015-03-18 23:18:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-19 03:19:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019023002/20001
5 years, 9 months ago (2015-03-19 03:38:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 04:16:52 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 04:17:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7046495e70e7878d9ff20788f0f54a61775cd5d
Cr-Commit-Position: refs/heads/master@{#321290}

Powered by Google App Engine
This is Rietveld 408576698