Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1019003002:
PPC: Use platform specific stubs for vector-based Load/KeyedLoad. (Closed)
|
Created:
5 years, 9 months ago by michael_dawson Modified:
5 years, 9 months ago CC:
v8-dev Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionPPC: Use platform specific stubs for vector-based Load/KeyedLoad.
Port 34a1a76ddf30109f7b6cb60aa2651493ab38660a
Original commit message:
A hydrogen code stub is not the best approach because it builds a frame
and doesn't have the technology to discard roots at tail call exits.
Platform-specific stubs provide much better performance at this point.
R=verwaest@chromium.org, mbrandy@us.ibm.com
BUG=
Committed: https://crrev.com/8977d6c973fbb7dc6c8ff416bf75f2742aa32d64
Cr-Commit-Position: refs/heads/master@{#27365}
Patch Set 1 #
Messages
Total messages: 18 (5 generated)
Matt when you are online can you review and add lgtm and then check the commit box.
On 2015/03/18 18:08:49, michael_dawson wrote: > Matt when you are online can you review and add lgtm and then check the commit > box. lgtm
The CQ bit was checked by michael_dawson@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019003002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
michael_dawson@ca.ibm.com changed reviewers: + svenpanne@chromium.org
On 2015/03/18 22:38:47, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Sven just wondering if I still need you to add lgtm or check the commit box.
On 2015/03/18 22:38:47, I haz the power (commit-bot) wrote: > No LGTM from a valid reviewer yet. Only full committers are accepted. > Even if an LGTM may have been provided, it was from a non-committer, > _not_ a full super star committer. > See http://www.chromium.org/getting-involved/become-a-committer > Note that this has nothing to do with OWNERS files. Sven just wondering if I still need you to add lgtm or check the commit box.
On 2015/03/20 00:00:50, michael_dawson wrote: > On 2015/03/18 22:38:47, I haz the power (commit-bot) wrote: > > No LGTM from a valid reviewer yet. Only full committers are accepted. > > Even if an LGTM may have been provided, it was from a non-committer, > > _not_ a full super star committer. > > See http://www.chromium.org/getting-involved/become-a-committer > > Note that this has nothing to do with OWNERS files. > > Sven just wondering if I still need you to add lgtm or check the commit box. I've stacked up our pending changes to the point where I did not do the next one because it does not apply without the earlier changes. After the 4 pending reviews we have another 5 more to catch up to commits that went in yesterday.
michael_dawson@ca.ibm.com changed reviewers: + danno@chromium.org
On 2015/03/20 00:30:51, michael_dawson wrote: > On 2015/03/20 00:00:50, michael_dawson wrote: > > On 2015/03/18 22:38:47, I haz the power (commit-bot) wrote: > > > No LGTM from a valid reviewer yet. Only full committers are accepted. > > > Even if an LGTM may have been provided, it was from a non-committer, > > > _not_ a full super star committer. > > > See http://www.chromium.org/getting-involved/become-a-committer > > > Note that this has nothing to do with OWNERS files. > > > > Sven just wondering if I still need you to add lgtm or check the commit box. > > I've stacked up our pending changes to the point where I did not do the next one > because it does not apply without the earlier changes. After the 4 pending > reviews we have another 5 more to catch up to commits that went in yesterday. Added Danno in case Sven is out of the office
Rubberstamp LGTM (in case you're not familiar with the term: that means I'm approving without actually reviewing) so you can land. IIUC what commit-bot is trying to tell us is that we have to make you guys committers in addition to being OWNERS.
The CQ bit was checked by michael_dawson@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019003002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8977d6c973fbb7dc6c8ff416bf75f2742aa32d64 Cr-Commit-Position: refs/heads/master@{#27365}
Message was sent while issue was closed.
On 2015/03/21 13:42:35, Jakob wrote: > Rubberstamp LGTM (in case you're not familiar with the term: that means I'm > approving without actually reviewing) so you can land. > > IIUC what commit-bot is trying to tell us is that we have to make you guys > committers in addition to being OWNERS. Thanks for the LGTM. Any chance you could do the same for the other 3 I added you as a reviewer to ? I have another ~10 backed up but I can't create the reviews as I need these in first. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
