Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1018983002: [DevTools] Support redirects in protocol handler generator. (Closed)

Created:
5 years, 9 months ago by vkuzkokov
Modified:
5 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support redirects in protocol handler generator. BUG= Committed: https://crrev.com/2840ec3bd5e5e590323b6d2e53df4159951cacd0 Cr-Commit-Position: refs/heads/master@{#321175}

Patch Set 1 : #

Patch Set 2 : Reuse tmpl_register #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 2 4 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vkuzkokov
Dmitry, is it important that we always redirect to a command with the same name ...
5 years, 9 months ago (2015-03-18 17:17:48 UTC) #3
dgozman
> Dmitry, is it important that we always redirect to a command with the same ...
5 years, 9 months ago (2015-03-18 17:30:12 UTC) #4
vkuzkokov
https://codereview.chromium.org/1018983002/diff/40001/content/browser/devtools/protocol/devtools_protocol_handler_generator.py File content/browser/devtools/protocol/devtools_protocol_handler_generator.py (right): https://codereview.chromium.org/1018983002/diff/40001/content/browser/devtools/protocol/devtools_protocol_handler_generator.py#newcode651 content/browser/devtools/protocol/devtools_protocol_handler_generator.py:651: command_map["TargetDomain"] = json_domain["domain"] On 2015/03/18 17:30:11, dgozman wrote: > ...
5 years, 9 months ago (2015-03-18 17:34:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018983002/60001
5 years, 9 months ago (2015-03-18 17:34:40 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-18 18:27:32 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 18:28:50 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2840ec3bd5e5e590323b6d2e53df4159951cacd0
Cr-Commit-Position: refs/heads/master@{#321175}

Powered by Google App Engine
This is Rietveld 408576698