Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1018953005: Do AllocateSharedMemory on FILE_USER_BLOCKING thread. (Closed)

Created:
5 years, 9 months ago by jbauman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do AllocateSharedMemory on FILE_USER_BLOCKING thread. This operation requires accessing the filesystem on OS X and linux and could be slow. BUG=466437 Committed: https://crrev.com/153e1323edbd20abe02626afdd29e0135443a047 Cr-Commit-Position: refs/heads/master@{#321267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jbauman
Obviously not as good as switching to mach memory objects, but this is simple enough ...
5 years, 9 months ago (2015-03-18 23:50:20 UTC) #2
Avi (use Gerrit)
LGTM
5 years, 9 months ago (2015-03-19 00:07:06 UTC) #3
erikchen
lgtm
5 years, 9 months ago (2015-03-19 00:12:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018953005/1
5 years, 9 months ago (2015-03-19 00:17:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 01:59:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 02:00:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/153e1323edbd20abe02626afdd29e0135443a047
Cr-Commit-Position: refs/heads/master@{#321267}

Powered by Google App Engine
This is Rietveld 408576698