 Chromium Code Reviews
 Chromium Code Reviews Issue 1018953004:
  Add SeccompSupportDetector for Android.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1018953004:
  Add SeccompSupportDetector for Android.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml | 
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml | 
| index 0d361e4473fa557ce783a67fdf6f31d6eafc83ac..b34f2f165fa3325881d7eef3c66f06169fe3ccfd 100644 | 
| --- a/tools/metrics/histograms/histograms.xml | 
| +++ b/tools/metrics/histograms/histograms.xml | 
| @@ -247,6 +247,31 @@ Therefore, the affected-histogram name has to have at least one dot in it. | 
| </summary> | 
| </histogram> | 
| +<histogram name="Android.KernelVersion" enum="AndroidKernelVersion"> | 
| + <owner>rsesek@chromium.org</owner> | 
| + <summary> | 
| + Reports the kernel major and minor version from the utsname.release field. | 
| + The low 16 bits of each version are combined into 32-bit integer. The range | 
| 
Ilya Sherman
2015/03/19 00:37:44
nit: "into 32-bit integer" -> "into a 32-bit integ
 
Robert Sesek
2015/03/19 14:57:30
Done.
 | 
| + is from [0x0002006,0x00040010] to track kernel versions 2.6 through 4.10. | 
| 
Ilya Sherman
2015/03/19 00:37:44
Did you mean 0x0004000a?  I'd expect 0x0010 to mea
 
Ilya Sherman
2015/03/19 00:37:44
Did you mean 0x00020006 (i.e. an extra 0)?
 
Robert Sesek
2015/03/19 14:57:30
Do'h. Thanks for catching that.
 
Robert Sesek
2015/03/19 14:57:30
Done.
 | 
| + </summary> | 
| +</histogram> | 
| + | 
| +<histogram name="Android.SeccompStatus.Prctl" enum="AndroidSeccompStatus"> | 
| + <owner>rsesek@chromium.org</owner> | 
| + <summary> | 
| + Reports the level of kernel support for the seccomp-bpf sandbox using | 
| + prctl(PR_SET_SECCOMP). | 
| + </summary> | 
| +</histogram> | 
| + | 
| +<histogram name="Android.SeccompStatus.Syscall" enum="AndroidSeccompStatus"> | 
| + <owner>rsesek@chromium.org</owner> | 
| + <summary> | 
| + Reports the level of kernel support for the seccomp-bpf sandbox using the | 
| + seccomp system call. | 
| + </summary> | 
| +</histogram> | 
| + | 
| <histogram name="AndroidTabCloseUndo.Toast" | 
| enum="AndroidTabCloseUndoToastEvent"> | 
| <owner>dtrainor@chromium.org</owner> | 
| @@ -44201,6 +44226,22 @@ Therefore, the affected-histogram name has to have at least one dot in it. | 
| <int value="4" label="EvictAll"/> | 
| </enum> | 
| +<enum name="AndroidKernelVersion" type="int"> | 
| + <int value="131078" label="2.6"/> | 
| + <int value="196608" label="3.0"/> | 
| + <int value="196611" label="3.3"/> | 
| + <int value="196612" label="3.4"/> | 
| + <int value="196616" label="3.8"/> | 
| + <int value="196624" label="3.10"/> | 
| + <int value="196628" label="3.14"/> | 
| + <int value="196631" label="3.17"/> | 
| + <int value="196632" label="3.18"/> | 
| + <int value="196633" label="3.19"/> | 
| + <int value="262144" label="4.0"/> | 
| + <int value="262145" label="4.01"/> | 
| + <int value="262160" label="4.10"/> | 
| +</enum> | 
| + | 
| <enum name="AndroidMemoryNotificationBackground" type="int"> | 
| <int value="0" label="TrimMemoryUiHidden"/> | 
| <int value="1" label="TrimMemoryBackground"/> | 
| @@ -44215,6 +44256,12 @@ Therefore, the affected-histogram name has to have at least one dot in it. | 
| <int value="3" label="LowMemory"/> | 
| </enum> | 
| +<enum name="AndroidSeccompStatus" type="int"> | 
| + <int value="0" label="Detection Failed"/> | 
| + <int value="1" label="Not Supported"/> | 
| + <int value="2" label="Supported"/> | 
| +</enum> | 
| + | 
| <enum name="AndroidSigninPromoAction" type="int"> | 
| <int value="0" label="Promo enabled"> | 
| The Android signin promo was enabled to show on next startup. |