Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1018953002: [Audio Player] Remove durationChanged hander in 'control-panel' element (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Audio Player] Remove durationChanged hander in 'control-panel' element It's no longer necessary. And the handler is fired unexpected timing after unminimized and causes the issue (see the issue for detail). This patch removes it. BUG=462065 TEST=browsertest passes Committed: https://crrev.com/c6bb664d869cc9189e322c0b0a1bcf45d9f9adce Cr-Commit-Position: refs/heads/master@{#321357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M ui/file_manager/audio_player/elements/control_panel.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
5 years, 9 months ago (2015-03-19 09:02:24 UTC) #2
fukino
lgtm
5 years, 9 months ago (2015-03-19 12:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018953002/1
5 years, 9 months ago (2015-03-19 14:23:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 14:49:57 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 14:50:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6bb664d869cc9189e322c0b0a1bcf45d9f9adce
Cr-Commit-Position: refs/heads/master@{#321357}

Powered by Google App Engine
This is Rietveld 408576698