Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1018923002: Adjust key behaviour for weak collections (Closed)

Created:
5 years, 9 months ago by rossberg
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adjust key behaviour for weak collections R=dslomov@chromium.org BUG=460083, v8:3970, v8:3971 LOG=Y Committed: https://crrev.com/7875a8912228bd5534de916834c8d46d5d987d39 Cr-Commit-Position: refs/heads/master@{#27272}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -52 lines) Patch
M src/weak-collection.js View 7 chunks +7 lines, -17 lines 0 comments Download
M test/mjsunit/es6/collections.js View 1 5 chunks +56 lines, -25 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/harmony/private.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rossberg
5 years, 9 months ago (2015-03-18 10:46:56 UTC) #1
Dmitry Lomov (no reviews)
lgtm % test https://codereview.chromium.org/1018923002/diff/1/test/mjsunit/es6/collections.js File test/mjsunit/es6/collections.js (right): https://codereview.chromium.org/1018923002/diff/1/test/mjsunit/es6/collections.js#newcode54 test/mjsunit/es6/collections.js:54: assertDoesNotThrow(function () { m.get(undefined) }); Validate ...
5 years, 9 months ago (2015-03-18 10:55:45 UTC) #2
rossberg
https://codereview.chromium.org/1018923002/diff/1/test/mjsunit/es6/collections.js File test/mjsunit/es6/collections.js (right): https://codereview.chromium.org/1018923002/diff/1/test/mjsunit/es6/collections.js#newcode54 test/mjsunit/es6/collections.js:54: assertDoesNotThrow(function () { m.get(undefined) }); On 2015/03/18 10:55:44, Dmitry ...
5 years, 9 months ago (2015-03-18 11:59:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018923002/20001
5 years, 9 months ago (2015-03-18 11:59:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 12:51:53 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 12:52:06 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7875a8912228bd5534de916834c8d46d5d987d39
Cr-Commit-Position: refs/heads/master@{#27272}

Powered by Google App Engine
This is Rietveld 408576698