Show deprecation warnings for header values in XHR according to RFC 7230

Source/platform/network/HTTPParsersTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "HTTPParsers.h"
 
 #include "wtf/MathExtras.h"
 #include "wtf/text/AtomicString.h"
 
@@ skipping 221 matching lines @@
     EXPECT_TRUE(set1.contains("whatever"));
     parseCommaDelimitedHeader("dprw\t     , fo\to", set2);
     EXPECT_FALSE(set2.contains("dpr"));
     EXPECT_FALSE(set2.contains("rw"));
     EXPECT_FALSE(set2.contains("whatever"));
     EXPECT_TRUE(set2.contains("dprw"));
     EXPECT_FALSE(set2.contains("foo"));
     EXPECT_TRUE(set2.contains("fo\to"));
 }
 
+TEST(HTTPParsersTest, HTTPFieldContent)
+{
+    EXPECT_TRUE(blink::isValidHTTPFieldContentRFC7230("\xd0\xa1"));
+    EXPECT_TRUE(blink::isValidHTTPFieldContentRFC7230("t t"));
+    EXPECT_TRUE(blink::isValidHTTPFieldContentRFC7230("t\tt"));
+    EXPECT_TRUE(blink::isValidHTTPFieldContentRFC7230(String("77?")));

[hiroshige, 2015/09/04 05:23:42]

Is this trying to test non-latin1 cases?
If so, isValidHTTPFieldContentRFC7230() should return false. How about code
like:

const UChar hiraganaA[2] = { 0x3042, 0 };
EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(String(hiraganaA)));

(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)

[shiva.jm, 2015/09/04 11:03:08]

Done.

+    EXPECT_TRUE(blink::isValidHTTPFieldContentRFC7230(String("?? Gem")));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(" "));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(""));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("\x7f"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t\rt"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t\nt"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t\bt"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t\vt"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(" t"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t "));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(String("t\0t", 3)));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(String("test \0 data")));

[hiroshige, 2015/09/04 05:23:42]

L259-L262 don't test null bytes, e.g. String("test \0 data") is equal to
String("test ").
How about testing:
  String("\0", 1)
  String("test \0", 6)
and removing "test \0 data" (a "t\0t" case is sufficient).

[shiva.jm, 2015/09/04 11:03:08]

Done.

+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("\0"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("test \0 data"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("test \0"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("test\r\n data"));
+}
+
 } // namespace blink