Show deprecation warnings for header values in XHR according to RFC 7230

Source/platform/network/HTTPParsersTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "HTTPParsers.h"
 
 #include "wtf/MathExtras.h"
 #include "wtf/text/AtomicString.h"
 
@@ skipping 221 matching lines @@
     EXPECT_TRUE(set1.contains("whatever"));
     parseCommaDelimitedHeader("dprw\t     , fo\to", set2);
     EXPECT_FALSE(set2.contains("dpr"));
     EXPECT_FALSE(set2.contains("rw"));
     EXPECT_FALSE(set2.contains("whatever"));
     EXPECT_TRUE(set2.contains("dprw"));
     EXPECT_FALSE(set2.contains("foo"));
     EXPECT_TRUE(set2.contains("fo\to"));
 }
 
+TEST(HTTPParsersTest, HTTPFieldContent)
+{
+    EXPECT_TRUE(blink::isValidHTTPFieldContentRFC7230("\xd0\xa1"));
+    EXPECT_TRUE(blink::isValidHTTPFieldContentRFC7230("t t"));
+    EXPECT_TRUE(blink::isValidHTTPFieldContentRFC7230("t\tt"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(" "));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(""));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("\x7f"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t\rt"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t\nt"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t\bt"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t\vt"));

[hiroshige, 2015/09/02 09:53:48]

Could you add
- a test for null bytes, e.g.
EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(String("t\0t", 3))); and
- a test for non-ASCII UTF-16 string (EXPECT_FALSE(...)).

isValidHTTPHeaderValue() rejects \0, \r, \n, and non-latin1 characters, which
should be also rejected by isValidHTTPFieldContentRFC7230().
\r and \n are tested, but \0 and non-latin1 are not.

+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230(" t"));
+    EXPECT_FALSE(blink::isValidHTTPFieldContentRFC7230("t "));
+}
+
 } // namespace blink