Show deprecation warnings for header values in XHR according to RFC 7230

Source/modules/fetch/FetchHeaderList.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/fetch/FetchHeaderList.h"
 
 #include "core/fetch/FetchUtils.h"
+#include "core/frame/UseCounter.h"
 #include "platform/network/HTTPParsers.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace blink {
 
 FetchHeaderList* FetchHeaderList::create()
 {
     return new FetchHeaderList();
 }
 
@@ skipping 127 matching lines @@
 {
     // "A name is a case-insensitive byte sequence that matches the field-name
     // token production."
     return isValidHTTPToken(name);
 }
 
 bool FetchHeaderList::isValidHeaderValue(const String& value)
 {
     // "A value is a byte sequence that matches the field-value token production
     // and contains no 0x0A or 0x0D bytes."
+
+    // Show deprecation warnings and count occurrences of such deprecated header values
+    if (isValidHTTPHeaderValueForFetch(value))

[hiroshige, 2015/08/27 11:38:08]

This should be "if (!isValidHTTPHeaderValueForFetch(value) &&
isValidHTTPHeaderValue(value))".

[shiva.jm, 2015/09/01 08:26:51]

Done.

[shiva.jm, 2015/09/01 08:26:51]

Done.

+        UseCounter::deprecationMessage(UseCounter::FetchHeaderValue);

[hiroshige, 2015/08/27 11:38:08]

Calling UseCounter::deprecationMessage() does nothing here (no warning, no
counter update).

An alternative is to call UseCounter::countDeprecation(ExecutionContext*, ...)
here and to add ExecutionContext* as a parameter of isValidHeaderValue().
This adds ExecutionContext* to many caller methods though.

+
     return isValidHTTPHeaderValue(value);
 }
 
 } // namespace blink