Show deprecation warnings for header values in XHR according to RFC 7230

Source/platform/network/HTTPParsers.cpp

 /*
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 89 matching lines @@
     unsigned start = pos;
     unsigned len = str.length();
     while (pos < len) {
         if (str[pos] == ' ' || str[pos] == '\t' || str[pos] == ';')
             break;
         ++pos;
     }
     return pos != start;
 }
 
-bool isValidHTTPHeaderValue(const String& name)
+// See RFC 7230, Section 3.2.3.
+bool isValidHTTPHeaderValue(const String& value)
 {
-    // FIXME: This should really match name against
-    // field-value in section 4.2 of RFC 2616.
+    UChar c = value[0];

[tkent, 2015/03/19 23:04:08]

Looks this has an out-of-bound access issue

nit: c -> firstCharacter

[shiva.jm, 2015/03/20 06:23:52]

These looks ok, if we just have value.length(), it will try to get character at
the end of string.

+    if (c == ' ' || c == '\t')
+        return false;
 
-    return name.containsOnlyLatin1() && !name.contains('\r') && !name.contains('\n') && !name.contains(static_cast<UChar>('\0'));
+    c = value[value.length() - 1];

[tkent, 2015/03/19 23:04:08]

c -> char lastCharacter

+    if (c == ' ' || c == '\t')
+        return false;
+
+    for (unsigned i = 0; i < value.length(); ++i) {
+        c = value[i];
+        if (c == 0x7F || c > 0xFF || (c < 0x20 && c != '\t'))
+        return false;

[tkent, 2015/03/19 23:04:08]

wrong indentation

[shiva.jm, 2015/03/20 06:23:52]

Done.

+    }
+
+    return true;
 }
 
-// See RFC 2616, Section 2.2.
-bool isValidHTTPToken(const String& characters)
+// See RFC 7230, Section 3.2.6.
+bool isValidHTTPToken(const String& value)
 {
-    if (characters.isEmpty())
+    if (value.isEmpty())
         return false;
-    for (unsigned i = 0; i < characters.length(); ++i) {
-        UChar c = characters[i];
+    for (unsigned i = 0; i < value.length(); ++i) {
+        UChar c = value[i];
         if (c <= 0x20 || c >= 0x7F
             || c == '(' || c == ')' || c == '<' || c == '>' || c == '@'
             || c == ',' || c == ';' || c == ':' || c == '\\' || c == '"'
             || c == '/' || c == '[' || c == ']' || c == '?' || c == '='
             || c == '{' || c == '}')
         return false;
     }
     return true;
 }
 
@@ skipping 723 matching lines @@
 
 void parseCommaDelimitedHeader(const String& headerValue, CommaDelimitedHeaderSet& headerSet)
 {
     Vector<String> results;
     headerValue.split(",", results);
     for (auto& value : results)
         headerSet.add(value.stripWhiteSpace(isWhitespace));
 }
 
 }