Issue 1018873002: [turbofan] Improve ChangeLowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1018873002: [turbofan] Improve ChangeLowering. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer

Modified:
5 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Improve ChangeLowering. - Use representation information provided by the type system to skip SMI checks. - Fix combining of ChangeTaggedToFloat64 with JSToNumber now that JS operators can produce control. - Remove the unnecessary abstraction of smi/field offsets. - Improve unit test coverage. - Various cosmetic fixes. R=svenpanne@chromium.org Committed: https://crrev.com/45434d575eef59fd5936f7eba0ba6b2fff4d642d Cr-Commit-Position: refs/heads/master@{#27250}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+360 lines, -303 lines)			Patch
M	src/compiler/change-lowering.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/change-lowering.cc	View	5 chunks	+129 lines, -76 lines	0 comments	Download
M	test/unittests/compiler/change-lowering-unittest.cc	View	13 chunks	+230 lines, -226 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018873002/1

5 years, 9 months ago (2015-03-18 07:26:15 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-18 07:27:53 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/45434d575eef59fd5936f7eba0ba6b2fff4d642d
Cr-Commit-Position: refs/heads/master@{#27250}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages