Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1018863003: Support BGR with DirectWrite. (Closed)

Created:
5 years, 9 months ago by bungeman-skia
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M src/ports/SkScalerContext_win_dw.cpp View 3 chunks +21 lines, -6 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bungeman-skia
So I'm not sure that this is actually fully correct, in that I'm just reversing ...
5 years, 9 months ago (2015-03-19 18:20:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018863003/1
5 years, 9 months ago (2015-03-19 18:20:44 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-19 18:20:44 UTC) #5
reed1
looks very clean! anyway to test it locally?
5 years, 9 months ago (2015-03-19 20:43:51 UTC) #6
reed1
Can you create a GM that has a tmp surface with BGR stripes, and then ...
5 years, 9 months ago (2015-03-19 20:44:59 UTC) #8
reed1
lgtm -- I'm ok if we had such a GM later
5 years, 9 months ago (2015-03-19 20:45:12 UTC) #9
bungeman-skia
On 2015/03/19 20:45:12, reed1 wrote: > lgtm -- I'm ok if we had such a ...
5 years, 9 months ago (2015-03-19 20:57:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018863003/1
5 years, 9 months ago (2015-03-19 20:57:31 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 20:57:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/12f03121bb76214b71677ac0208d74c3c56c3b1f

Powered by Google App Engine
This is Rietveld 408576698