crashpad_database_util: add --new-report

client/crash_report_database.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 88 matching lines @@
     FileHandle handle;
 
     //! A unique identifier by which this report will always be known to the
     //! database.
     UUID uuid;
 
     //! The path to the crash report being written.
     base::FilePath path;
   };
 
+  //! \brief A scoper to cleanly handle the interface requirement imposed by
+  //!     PrepareNewCrashReport().
+  //!
+  //! Calls ErrorWritingCrashReport() upon destruction unless disarmed by
+  //! calling Disarm(). Armed upon construction.
+  class CallErrorWritingCrashReport {
+   public:
+    //! \brief Arms the object to call ErrorWritingCrashReport() on \a database
+    //!     with an argument of \a new_report on destruction.
+    CallErrorWritingCrashReport(CrashReportDatabase* database,
+                                NewReport* new_report);
+
+    //! \brief Calls ErrorWritingCrashReport() if the object is armed.
+    ~CallErrorWritingCrashReport();
+
+    //! \brief Disarms the object so that CallErrorWritingCrashReport() will not
+    //!     be called upon destruction.
+    void Disarm();
+
+   private:
+    CrashReportDatabase* database_;  // weak
+    NewReport* new_report_;  // weak
+
+    DISALLOW_COPY_AND_ASSIGN(CallErrorWritingCrashReport);
+  };
+
   //! \brief The result code for operations performed on a database.
   enum OperationStatus {
     //! \brief No error occurred.
     kNoError = 0,
 
     //! \brief The report that was requested could not be located.
     kReportNotFound,
 
     //! \brief An error occured while performing a file operation on a crash
     //!     report.
@@ skipping 30 matching lines @@
 
   //! \brief Returns the Settings object for this database.
   //!
   //! \return A weak pointer to the Settings object, which is owned by the
   //!     database.
   virtual Settings* GetSettings() = 0;
 
   //! \brief Creates a record of a new crash report.
   //!
   //! Callers can then write the crash report using the file handle provided.
-  //! The caller does not own this handle, and it must be explicitly closed with
+  //! The caller does not own the new crash report record or its file handle,
+  //! both of which must be explicitly disposed of by calling
   //! FinishedWritingCrashReport() or ErrorWritingCrashReport().
   //!
-  //! \param[out] report A file handle to which the crash report data should be
-  //!     written. Only valid if this returns #kNoError. The caller must not
-  //!     close this handle.
+  //! To arrange to call ErrorWritingCrashReport() during any early return, use
+  //! CallErrorWritingCrashReport.
+  //!
+  //! \param[out] report A NewReport object containing a file handle to which
+  //!     the crash report data should be written. Only valid if this returns
+  //!     #kNoError. The caller must not delete the NewReport object or close
+  //!     the file handle within.
   //!
   //! \return The operation status code.
   virtual OperationStatus PrepareNewCrashReport(NewReport** report) = 0;
 
   //! \brief Informs the database that a crash report has been written.
   //!
   //! After calling this method, the database is permitted to move and rename
   //! the file at NewReport::path.
   //!
-  //! \param[in] report A handle obtained with PrepareNewCrashReport(). The
-  //!     handle will be invalidated as part of this call.
+  //! \param[in] report A NewReport obtained with PrepareNewCrashReport(). The
+  //!     NewReport object and file handle within will be invalidated as part of
+  //!     this call.
   //! \param[out] uuid The UUID of this crash report.
   //!
   //! \return The operation status code.
   virtual OperationStatus FinishedWritingCrashReport(NewReport* report,
                                                      UUID* uuid) = 0;
 
   //! \brief Informs the database that an error occurred while attempting to
   //!     write a crash report, and that any resources associated with it should
   //!     be cleaned up.
   //!
   //! After calling this method, the database is permitted to remove the file at
   //! NewReport::path.
   //!
-  //! \param[in] report A handle obtained with PrepareNewCrashReport(). The
-  //!     handle will be invalidated as part of this call.
+  //! \param[in] report A NewReport obtained with PrepareNewCrashReport(). The
+  //!     NewReport object and file handle within will be invalidated as part of
+  //!     this call.
   //!
   //! \return The operation status code.
   virtual OperationStatus ErrorWritingCrashReport(NewReport* report) = 0;
 
   //! \brief Returns the crash report record for the unique identifier.
   //!
   //! \param[in] uuid The crash report record unique identifier.
   //! \param[out] report A crash report record. Only valid if this returns
   //!     #kNoError.
   //!
@@ skipping 69 matching lines @@
  protected:
   CrashReportDatabase() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CrashReportDatabase);
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_CLIENT_CRASH_REPORT_DATABASE_H_