Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1874)

Issue 1018853005: Files.app: Obtain total bytes of upload task before starting tasks. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Obtain total bytes of upload task before starting tasks. BUG=450630 TEST=None Committed: https://crrev.com/8657128fc89846a105dc176154e8ce445c10a838 Cr-Commit-Position: refs/heads/master@{#321515}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix. #

Patch Set 4 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -28 lines) Patch
M chrome/browser/chromeos/drive/job_scheduler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 1 2 3 4 chunks +37 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hirono
PTAL, This is need to let Files.app show the progress of total sync tasks instead ...
5 years, 9 months ago (2015-03-19 11:53:18 UTC) #2
fukino
lgtm. Thank you! https://codereview.chromium.org/1018853005/diff/20001/chrome/browser/chromeos/drive/job_scheduler.cc File chrome/browser/chromeos/drive/job_scheduler.cc (right): https://codereview.chromium.org/1018853005/diff/20001/chrome/browser/chromeos/drive/job_scheduler.cc#newcode150 chrome/browser/chromeos/drive/job_scheduler.cc:150: // Obtains file size to be ...
5 years, 9 months ago (2015-03-20 03:27:12 UTC) #3
hirono
Thanks! https://codereview.chromium.org/1018853005/diff/20001/chrome/browser/chromeos/drive/job_scheduler.cc File chrome/browser/chromeos/drive/job_scheduler.cc (right): https://codereview.chromium.org/1018853005/diff/20001/chrome/browser/chromeos/drive/job_scheduler.cc#newcode150 chrome/browser/chromeos/drive/job_scheduler.cc:150: // Obtains file size to be uploaded for ...
5 years, 9 months ago (2015-03-20 03:38:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018853005/60001
5 years, 9 months ago (2015-03-20 03:51:25 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-20 04:23:20 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 04:24:00 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8657128fc89846a105dc176154e8ce445c10a838
Cr-Commit-Position: refs/heads/master@{#321515}

Powered by Google App Engine
This is Rietveld 408576698