[Icons NTP] FaviconService: Add method to retrieve large icon.

components/favicon/core/browser/favicon_service.cc

Index: components/favicon/core/browser/favicon_service.cc
diff --git a/components/favicon/core/browser/favicon_service.cc b/components/favicon/core/browser/favicon_service.cc
index f0173e41e6e08e63e3bc46c7321cb292136f53c4..dd15a4933df39849c3acf6944eba5ad0558daa08 100644
--- a/components/favicon/core/browser/favicon_service.cc
+++ b/components/favicon/core/browser/favicon_service.cc
@@ -200,6 +200,31 @@ base::CancelableTaskTracker::TaskId FaviconService::GetFaviconForPageURL(
 }
 
 base::CancelableTaskTracker::TaskId
+FaviconService::GetGenericLargeIconForPageURL(
+    const GURL& page_url,
+    int desired_size_in_pixel,
+    const favicon_base::FaviconRawBitmapCallback& callback,
+    base::CancelableTaskTracker* tracker) {
+  favicon_base::FaviconResultsCallback favicon_results_callback =
+      Bind(&FaviconService::RunFaviconRawBitmapCallbackWithBitmapResults,

[beaudoin, 2015/03/17 23:42:50]

RunFaviconRawBitmapCallbackWithBitmapResults looks like it can perform the
resizing if you don't bind 0 desired_size_in_pixel, but from your other CL you
perform the resizing yourself in the endpoint. I suspect there is a reason for
this, but you should explain it in a comment. (If not, then it looks like
GetRawFavicon() is almost a 1:1 match for this method.) 

[huangs, 2015/03/18 20:31:37]

Nope, just an oversight.  Using this to do resize now, and removing redundant
code in the other CL.

[beaudoin, 2015/03/19 02:36:27]

Why define this and not use GetRawFavicon directly passing
icon_type = favicon_base::TOUCH_ICON | favicon_base::TOUCH_PRECOMPOSED_ICON ? It
looks like a perfect copy of this function.

[huangs, 2015/03/19 14:46:29]

That would be GetRawFaviconForPageURL(), but the idea works!  We'll still need
to do work in FaviconService to accommodate large *fav*icons, but for now we can
skip this patch so the next one is unblocked.

+           base::Unretained(this),
+           callback,
+           0);
+  if (history_service_) {
+    int icon_types =
+        favicon_base::TOUCH_ICON | favicon_base::TOUCH_PRECOMPOSED_ICON;
+    std::vector<int> desired_sizes_in_pixel;
+    desired_sizes_in_pixel.push_back(desired_size_in_pixel);
+    return history_service_->GetFaviconsForURL(page_url,
+                                               icon_types,
+                                               desired_sizes_in_pixel,
+                                               favicon_results_callback,
+                                               tracker);
+  }
+  return RunWithEmptyResultAsync(favicon_results_callback, tracker);
+}
+
+base::CancelableTaskTracker::TaskId
 FaviconService::UpdateFaviconMappingsAndFetch(
     const GURL& page_url,
     const std::vector<GURL>& icon_urls,