Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/browser/background/background_mode_manager_unittest.cc

Issue 1018643003: Removing chrome.pushMessaging API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updates to documentation per kalman's comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_mode_manager_unittest.cc
diff --git a/chrome/browser/background/background_mode_manager_unittest.cc b/chrome/browser/background/background_mode_manager_unittest.cc
index 94a1d853180b111df14d9ef8a6850ce1e525a224..7b5850325e73e3af1c3fe55b10043225e9df126c 100644
--- a/chrome/browser/background/background_mode_manager_unittest.cc
+++ b/chrome/browser/background/background_mode_manager_unittest.cc
@@ -873,15 +873,6 @@ TEST_F(BackgroundModeManagerWithExtensionsTest, BalloonDisplay) {
"\"permissions\": [\"background\"]}",
"ID-2"));
- scoped_refptr<extensions::Extension> ephemeral_app(
- CreateExtension(
- extensions::Manifest::COMMAND_LINE,
- "{\"name\": \"Ephemeral App\", "
- "\"version\": \"1.0\","
- "\"manifest_version\": 2,"
- "\"permissions\": [\"pushMessaging\"]}",
- "ID-3"));
-
static_cast<extensions::TestExtensionSystem*>(
extensions::ExtensionSystem::Get(profile_))
->CreateExtensionService(base::CommandLine::ForCurrentProcess(),
@@ -923,14 +914,4 @@ TEST_F(BackgroundModeManagerWithExtensionsTest, BalloonDisplay) {
// show the balloon.
service->AddExtension(upgraded_no_bg_ext_has_bg.get());
EXPECT_TRUE(manager_->HasShownBalloon());
-
- // Installing an ephemeral app should not show the balloon.
- manager_->SetHasShownBalloon(false);
- AddEphemeralApp(ephemeral_app.get(), service);
- EXPECT_FALSE(manager_->HasShownBalloon());
-
- // Promoting the ephemeral app to a regular installed app should now show
- // the balloon.
- service->PromoteEphemeralApp(ephemeral_app.get(), false /* from sync */);
- EXPECT_TRUE(manager_->HasShownBalloon());
}

Powered by Google App Engine
This is Rietveld 408576698