Removing chrome.pushMessaging API

chrome/browser/background/background_application_list_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background/background_application_list_model.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/stl_util.h"
@@ skipping 262 matching lines @@
        cursor != extensions_.end();
        ++cursor, ++position) {
     if (id == cursor->get()->id())
       return position;
   }
   NOTREACHED();
   return -1;
 }
 
 // static
-bool BackgroundApplicationListModel::RequiresBackgroundModeForPushMessaging(
-    const Extension& extension) {
-  // No PushMessaging permission - does not require the background mode.
-  if (!extension.permissions_data()->HasAPIPermission(
-          APIPermission::kPushMessaging)) {
-    return false;
-  }
-
-  // If in the whitelist, then does not require background mode even if
-  // uses push messaging.
-  // TODO(dimich): remove this whitelist once we have a better way to keep
-  // listening for GCM. http://crbug.com/311268
-  std::string hexencoded_id_hash =
-      crx_file::id_util::HashedIdInHex(extension.id());
-  // The id starting from "9A04..." is a one from unit test.
-  if (hexencoded_id_hash == "C41AD9DCD670210295614257EF8C9945AD68D86E" ||
-      hexencoded_id_hash == "9A0417016F345C934A1A88F55CA17C05014EEEBA")
-     return false;
-
-  return true;
-}
-
-// static
 bool BackgroundApplicationListModel::IsBackgroundApp(
     const Extension& extension, Profile* profile) {
   // An extension is a "background app" if it has the "background API"
   // permission, and meets one of the following criteria:
   // 1) It is an extension (not a hosted app).
   // 2) It is a hosted app, and has a background contents registered or in the
   //    manifest.
 
   // Ephemeral apps are denied any background activity after their event page
   // has been destroyed, thus they cannot be background apps.
   if (extensions::util::IsEphemeralApp(extension.id(), profile))
     return false;
 
-  // Not a background app if we don't have the background permission or
-  // the push messaging permission
+  // Not a background app if we don't have the background permission.
   if (!extension.permissions_data()->HasAPIPermission(
-          APIPermission::kBackground) &&
-      !RequiresBackgroundModeForPushMessaging(extension))
+          APIPermission::kBackground)) {
     return false;
+  }
 
   // Extensions and packaged apps with background permission are always treated
   // as background apps.
   if (!extension.is_hosted_app())
     return true;
 
   // Hosted apps with manifest-provided background pages are background apps.
   if (extensions::BackgroundInfo::HasBackgroundPage(&extension))
     return true;
 
@@ skipping 117 matching lines @@
          (*old_cursor)->name() == (*new_cursor)->name() &&
          (*old_cursor)->id() == (*new_cursor)->id()) {
     ++old_cursor;
     ++new_cursor;
   }
   if (old_cursor != extensions_.end() || new_cursor != extensions.end()) {
     extensions_ = extensions;
     FOR_EACH_OBSERVER(Observer, observers_, OnApplicationListChanged(profile_));
   }
 }