Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1018613003: Introduce Blink APIs for supporting ServiceWorkerRegistration.getNotifications() (Closed)

Created:
5 years, 9 months ago by Peter Beverloo
Modified:
5 years, 9 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, dglazkov+blink, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce Blink APIs for supporting ServiceWorkerRegistration.getNotifications() This patch introduces the Blink APIs needed for supporting the new ServiceWorkerRegistration.getNotifications() method, enabling Web developers to get a list of all their open persistent notifications. This feature is part of the following Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/gb8QoBKJnGU/jKcPVOtnEVoJ This CL is part of a three-sided patch: [1] This CL. [2] https://codereview.chromium.org/1014073002/ [3] https://codereview.chromium.org/1016843002/ BUG=442143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M Source/bindings/core/v8/CallbackPromiseAdapter.h View 1 chunk +31 lines, -0 lines 0 comments Download
M public/platform/modules/notifications/WebNotificationManager.h View 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Peter Beverloo
+johnme for notifications +mkwst, mostly for CallbackPromiseAdapter.h I really don't like that I have to ...
5 years, 9 months ago (2015-03-17 17:40:03 UTC) #2
johnme
non-owner lgtm for WebNotificationManager.h (didn't review CallbackPromiseAdapter in detail)
5 years, 9 months ago (2015-03-17 19:42:15 UTC) #3
Mike West
LGTM. Overloading it here is probably fine, as I also can't think of a template-based ...
5 years, 9 months ago (2015-03-17 20:11:20 UTC) #4
haraken
bindings/ LGTM
5 years, 9 months ago (2015-03-18 01:05:22 UTC) #6
yhirano
bindings/ lgtm
5 years, 9 months ago (2015-03-18 01:36:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018613003/1
5 years, 9 months ago (2015-03-19 14:46:45 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 18:03:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192183

Powered by Google App Engine
This is Rietveld 408576698