Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: Source/core/html/track/TextTrackContainer.h

Issue 1018593004: Implement <video controls> dodging for text track layout (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: ready for review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackContainer.h
diff --git a/Source/core/html/track/TextTrackContainer.h b/Source/core/html/track/TextTrackContainer.h
index 662232184c43968a0e40294ea2c00faa2770752a..03d745960b77142048c7ec24fa67bf0cec026ca2 100644
--- a/Source/core/html/track/TextTrackContainer.h
+++ b/Source/core/html/track/TextTrackContainer.h
@@ -40,7 +40,14 @@ class TextTrackContainer final : public HTMLDivElement {
public:
static PassRefPtrWillBeRawPtr<TextTrackContainer> create(Document&);
- void updateDisplay(HTMLMediaElement&);
+ // Runs the "rules for updating the text track rendering". The
+ // ExposingControls enum is used in the WebVTT processing model to reset the
+ // layout when the media controls become visible, to avoid overlapping them.
+ enum ExposingControls {
+ DidNotStartExposingControls,
+ DidStartExposingControls
+ };
+ void updateDisplay(HTMLMediaElement&, ExposingControls);
private:
TextTrackContainer(Document&);

Powered by Google App Engine
This is Rietveld 408576698