LayoutTests/media/track/track-cue-rendering-after-controls-added.html - Issue 1018593004: Implement <video controls> dodging for text track layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/track/track-cue-rendering-after-controls-added.html

Issue 1018593004: Implement <video controls> dodging for text track layout (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: ready for review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html » ('j') | Source/core/html/shadow/MediaControlElements.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/track/track-cue-rendering-after-controls-added.html

diff --git a/LayoutTests/media/track/track-webvtt-two-cue-layout-after-first-end.html b/LayoutTests/media/track/track-cue-rendering-after-controls-added.html

similarity index 63%

copy from LayoutTests/media/track/track-webvtt-two-cue-layout-after-first-end.html

copy to LayoutTests/media/track/track-cue-rendering-after-controls-added.html

index 6cfb91990272af772c58adfc01560bbe092f652f..84b9b8921483d9957a30644b3834d702a68e4575 100644

--- a/LayoutTests/media/track/track-webvtt-two-cue-layout-after-first-end.html

+++ b/LayoutTests/media/track/track-cue-rendering-after-controls-added.html

@@ -1,5 +1,10 @@

<!DOCTYPE html>

-<title>WebVTT two-cue layout after the first cue has ended</title>

+<title>Text track cue layout after controls are added</title>

+<style>

+::cue {

+ font-size: 50px;

+</style>

@@ -9,18 +14,17 @@

// cue layout is done, so make no attempt to work without testRunner.

testRunner.waitUntilDone();

-// Add two cues, where the first cue ends before the second.

+// Add a cue that will overlap with the video controls.

var video = document.querySelector("video");

var track = video.addTextTrack("captions");

-track.addCue(new VTTCue(0, 1, "cue 1"));

-track.addCue(new VTTCue(0, 3, "cue 2"));

+track.addCue(new VTTCue(0, 1, "text"));

track.mode = "showing";

video.onloadeddata = function() {

testRunner.displayAsyncThen(function() {

- // Seek past the end of the first cue. The second cue should not move.

- video.currentTime = 2;

- video.onseeked = function() { testRunner.notifyDone(); };

+ // Add the controls. The cue should move to avoid overlap.

+ video.controls = true;

+ testRunner.notifyDone();

});

};

</script>