Implement <video controls> dodging for text track layout

Source/core/html/shadow/MediaControlElements.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 113 matching lines @@
 }
 
 void MediaControlPanelElement::transitionTimerFired(Timer<MediaControlPanelElement>*)
 {
     if (!m_opaque)
         hide();
 
     stopTimer();
 }
 
+void MediaControlPanelElement::didBecomeVisible()
+{
+    ASSERT(m_isDisplayed && m_opaque);
+    mediaElement().mediaControlsDidBecomeVisible();
+}
+
 void MediaControlPanelElement::makeOpaque()
 {
     if (m_opaque)
         return;
 
     setInlineStyleProperty(CSSPropertyOpacity, 1.0, CSSPrimitiveValue::CSS_NUMBER);
     m_opaque = true;
 
-    if (m_isDisplayed)
+    if (m_isDisplayed) {
         show();
+        didBecomeVisible();
+    }
 }
 
 void MediaControlPanelElement::makeTransparent()
 {
     if (!m_opaque)
         return;
 
     setInlineStyleProperty(CSSPropertyOpacity, 0.0, CSSPrimitiveValue::CSS_NUMBER);
 
     m_opaque = false;
     startTimer();
 }
 
 void MediaControlPanelElement::setIsDisplayed(bool isDisplayed)
 {
+    if (m_isDisplayed == isDisplayed)
+        return;
+
     m_isDisplayed = isDisplayed;
+    if (m_isDisplayed && m_opaque) {

[fs, 2015/03/20 09:58:54]

Nit: Unneeded {}

[philipj_slow, 2015/03/20 16:46:33]

Oops.

+        didBecomeVisible();
+    }
 }
 
 bool MediaControlPanelElement::keepEventInNode(Event* event)
 {
     return isUserInteractionEvent(event);
 }
 
 // ----------------------------
 
 MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement(MediaControls& mediaControls)
@@ skipping 422 matching lines @@
 }
 
 PassRefPtrWillBeRawPtr<MediaControlCurrentTimeDisplayElement> MediaControlCurrentTimeDisplayElement::create(MediaControls& mediaControls)
 {
     RefPtrWillBeRawPtr<MediaControlCurrentTimeDisplayElement> element = adoptRefWillBeNoop(new MediaControlCurrentTimeDisplayElement(mediaControls));
     element->setShadowPseudoId(AtomicString("-webkit-media-controls-current-time-display", AtomicString::ConstructFromLiteral));
     return element.release();
 }
 
 } // namespace blink