Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 1018553002: Autofill: Fix broken DCHECK from r320637. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/form_autofill_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/form_autofill_util.cc
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc
index 5977300794df57f4e2269a4affb18d958c5abf51..fce56a0d1d85a08442536514ee05b096603afde5 100644
--- a/components/autofill/content/renderer/form_autofill_util.cc
+++ b/components/autofill/content/renderer/form_autofill_util.cc
@@ -134,9 +134,9 @@ bool SatisfiesRequireAutocomplete(const WebInputElement& input_element) {
return input_element.autoComplete();
}
-// Returns the colspan for a <td>. Defaults to 1.
+// Returns the colspan for a <td> / <th>. Defaults to 1.
size_t CalculateTableCellColumnSpan(const WebElement& element) {
- DCHECK(element.hasHTMLTagName("td"));
+ DCHECK(element.hasHTMLTagName("td") || element.hasHTMLTagName("th"));
size_t span = 1;
if (element.hasAttribute("colspan")) {
« no previous file with comments | « chrome/renderer/autofill/form_autofill_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698