Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5462)

Unified Diff: chrome/browser/ui/webui/downloads_ui_browsertest.js

Issue 1018543005: downloads: fix Resume/Pause focus regression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/downloads_ui_browsertest.js
diff --git a/chrome/browser/ui/webui/downloads_ui_browsertest.js b/chrome/browser/ui/webui/downloads_ui_browsertest.js
index d7f1d4473e6e65ad7e7cc9edbe8d92f462ea44ad..07588cd817b5be7fadfc2a0bf289f878a2e75652 100644
--- a/chrome/browser/ui/webui/downloads_ui_browsertest.js
+++ b/chrome/browser/ui/webui/downloads_ui_browsertest.js
@@ -10,7 +10,6 @@ TEST_F('BaseDownloadsWebUITest', 'DeleteAllowed', function() {
this.expectDeleteControlsVisible(true);
// TODO(pamg): Mock out the back-end calls, so we can also test removing a
// single item.
- testDone();
});
TEST_F('BaseDownloadsWebUITest', 'NoResultsHiddenWhenDownloads', function() {
@@ -43,6 +42,36 @@ TEST_F('BaseDownloadsWebUITest', 'NoDownloadsAfterClearAll', function() {
this.checkShowing(noResults, loadTimeData.getString('no_downloads'));
});
+TEST_F('BaseDownloadsWebUITest', 'PauseResumeFocus', function() {
+ var manager = downloads.Manager.getInstance();
+ assertGE(manager.size(), 0);
+
+ var lastId = manager.items_.slice(-1)[0].view.id_;
+ var freshData = this.createDownload(lastId, Date.now());
+ freshData.state = downloads.Item.States.IN_PROGRESS;
+ freshData.resume = false;
+ downloads.Manager.updateItem(freshData);
+
+ var node = manager.idMap_[lastId].view.node;
+ var pause = node.querySelector('.pause');
+ var resume = node.querySelector('.resume');
+
+ expectFalse(pause.hidden);
+ expectTrue(resume.hidden);
+ // Move the focus to "Pause" then pretend the download was resumed. The focus
+ // should move to the equivalent button ("Resume" in this case).
+ pause.focus();
+ assertEquals(document.activeElement, pause);
+
+ freshData.state = downloads.Item.States.PAUSED;
+ freshData.resume = true;
+ downloads.Manager.updateItem(freshData);
+
+ expectTrue(pause.hidden);
+ expectFalse(resume.hidden);
+ expectEquals(document.activeElement, resume);
+});
+
/**
* @constructor
* @extends {BaseDownloadsWebUITest}
@@ -95,7 +124,6 @@ TEST_F('DownloadsWebUIDeleteProhibitedTest', 'DeleteProhibited', function() {
this.expectDeleteControlsVisible(false);
// TODO(pamg): Mock out the back-end calls, so we can also test removing a
// single item.
- testDone();
});
TEST_F('DownloadsWebUIDeleteProhibitedTest', 'ClearLeavesSearch', function() {
« no previous file with comments | « chrome/browser/resources/downloads/manager.js ('k') | chrome/browser/ui/webui/downloads_ui_browsertest_base.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698