Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 1018543005: downloads: fix Resume/Pause focus regression. (Closed)

Created:
5 years, 9 months ago by Dan Beam
Modified:
5 years, 9 months ago
Reviewers:
asanka, hcarmona
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

downloads: fix Resume/Pause focus regression. R=hcarmona@chromium.org BUG=467513 Committed: https://crrev.com/74970af30f740c8d1ea56251cbba16d91ce425b8 Cr-Commit-Position: refs/heads/master@{#320950}

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -28 lines) Patch
M chrome/browser/resources/downloads/focus_row.js View 2 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/resources/downloads/manager.js View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui_browsertest.js View 1 3 chunks +30 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui_browsertest_base.js View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Dan Beam
5 years, 9 months ago (2015-03-17 01:44:20 UTC) #1
hcarmona
lgtm
5 years, 9 months ago (2015-03-17 17:28:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018543005/20001
5 years, 9 months ago (2015-03-17 17:28:44 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-17 17:28:46 UTC) #6
Dan Beam
+asanka
5 years, 9 months ago (2015-03-17 17:34:25 UTC) #8
asanka
rbrstmp lgtm
5 years, 9 months ago (2015-03-17 18:21:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018543005/20001
5 years, 9 months ago (2015-03-17 18:34:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 19:04:38 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 19:05:28 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74970af30f740c8d1ea56251cbba16d91ce425b8
Cr-Commit-Position: refs/heads/master@{#320950}

Powered by Google App Engine
This is Rietveld 408576698