Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1018543003: PPC: Force PPC linux to use gcc and gcc 4.8.3 changes for AIX (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Force PPC linux to use gcc and gcc 4.8.3 changes for AIX - We don't have clang for PPC, force use of gcc. - Changes needed to compile/build on AIX with gcc 4.8.3 missed from last review modified: build/standalone.gypi R=danno@chromium.org, svenpanne@chromium.org BUG= Committed: https://crrev.com/a7bb84a452ec80f1d5baaffc2c122e98e8127227 Cr-Commit-Position: refs/heads/master@{#27254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M build/standalone.gypi View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
michael_dawson
Use gcc instead of clang for PPC and changes to allow build with gcc 4.8.3 ...
5 years, 9 months ago (2015-03-17 00:51:04 UTC) #1
Sven Panne
LGTM, but it would be good if Jochen had a look, too...
5 years, 9 months ago (2015-03-17 07:32:40 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-18 08:06:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018543003/1
5 years, 9 months ago (2015-03-18 08:08:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 08:42:19 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 08:42:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7bb84a452ec80f1d5baaffc2c122e98e8127227
Cr-Commit-Position: refs/heads/master@{#27254}

Powered by Google App Engine
This is Rietveld 408576698