Issue 1018523008: Revert of replace SkFixedDiv impl with native 64bit math

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1018523008: Revert of replace SkFixedDiv impl with native 64bit math (Closed)

Created:
5 years, 9 months ago by reed2

Modified:
5 years, 9 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of replace SkFixedDiv impl with native 64bit math (patchset #2 id:20001 of https://codereview.chromium.org/1022543003/) Reason for revert: http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53096 layouttests failures Original issue's description: > replace SkFixedDiv impl with native 64bit math > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/7c44ca926bf42b3b2e56131f250c0fd58f87ac71 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/effcba4a4d1a6fdfdd5ec440e10e1424b768182d

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -48 lines)			Patch
	M	bench/MathBench.cpp	View		1 chunk	+0 lines, -44 lines	0 comments	Download
	M	include/core/SkFixed.h	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

reed2

Created Revert of replace SkFixedDiv impl with native 64bit math

5 years, 9 months ago (2015-03-19 11:10:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018523008/1

5 years, 9 months ago (2015-03-19 11:10:35 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-19 11:10:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/effcba4a4d1a6fdfdd5ec440e10e1424b768182d