tools/metrics/histograms/histograms.xml - Issue 1018523007: ChromeOS: Do not show the error dialog when captive portal is detected in OOBE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1018523007: ChromeOS: Do not show the error dialog when captive portal is detected in OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: UMA metric added. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc ('K') | « chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 35c3c071a86a9d8d52a18c6df008a67fe2997faa..da491415b6ce5e3692d97c7177f016864dae8222 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -2294,6 +2294,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="CaptivePortal.RedirectTime" units="milliseconds">

+ <owner>alemate@chromium.org</owner>

+ <summary>

+ Number of milliseconds passed before captive portal performs redirect

Ilya Sherman 2015/03/24 18:18:35 Please document what the start time is.

Ilya Sherman 2015/03/24 18:18:35 nit: "passed" - "elapsed"

Ilya Sherman 2015/03/24 18:18:36 nit: Please end the sentence with a period.

Alexander Alekseev 2015/03/25 13:05:23 Done.

+ </summary>

+</histogram>

<owner>alemate@chromium.org</owner>

« chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc ('K') | « chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc ('k') | no next file » | no next file with comments »