ChromeOS: Do not show the error dialog when captive portal is detected in OOBE.

ChromeOS: Do not show the error dialog when captive portal is detected in OOBE.

BUG=449582
TEST=manual

Committed: https://crrev.com/bcb37a14572ef5c7f13a6bc75e4a4b65cabb9ec7
Cr-Commit-Position: refs/heads/master@{#322230}

[Alexander Alekseev, 2015-03-18 19:50:20]

alemate@chromium.org changed reviewers:
+ antrim@chromium.org

[Alexander Alekseev, 2015-03-18 19:50:20]

Please review.

[Denis Kuznetsov (DE-MUC), 2015-03-20 12:04:58]

https://codereview.chromium.org/1018523007/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/update_screen.cc (right):

https://codereview.chromium.org/1018523007/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/update_screen.cc:72: const int
kDelayErrorMessageSec = 10;
I believe that 10 seconds can be too much here. Have you clarified this number?

[Alexander Alekseev, 2015-03-24 11:33:15]

alemate@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Alexander Alekseev, 2015-03-24 11:33:15]

+nkostylev@ , please review.

[Nikita (slow), 2015-03-24 11:41:35]

https://codereview.chromium.org/1018523007/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/update_screen.cc (right):

https://codereview.chromium.org/1018523007/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/update_screen.cc:72: const int
kDelayErrorMessageSec = 10;
On 2015/03/20 12:04:58, Denis Kuznetsov wrote:
> I believe that 10 seconds can be too much here. Have you clarified this
number?

As discussed, OK to use this timeout + add UMA metric.

[Alexander Alekseev, 2015-03-24 14:32:52]

alemate@chromium.org changed reviewers:
+ isherman@chromium.org

[Alexander Alekseev, 2015-03-24 14:32:52]

+isherman@ : please review tools/metrics/histograms/histograms.xml

https://codereview.chromium.org/1018523007/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/update_screen.cc (right):

https://codereview.chromium.org/1018523007/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/update_screen.cc:72: const int
kDelayErrorMessageSec = 10;
On 2015/03/24 11:41:35, Nikita Kostylev wrote:
> On 2015/03/20 12:04:58, Denis Kuznetsov wrote:
> > I believe that 10 seconds can be too much here. Have you clarified this
> number?
> 
> As discussed, OK to use this timeout + add UMA metric.

Done.

[Nikita (slow), 2015-03-24 14:34:20]

On 2015/03/24 14:32:52, Alexander Alekseev wrote:
> +isherman@ : please review tools/metrics/histograms/histograms.xml
> 
>
https://codereview.chromium.org/1018523007/diff/1/chrome/browser/chromeos/log...
> File chrome/browser/chromeos/login/screens/update_screen.cc (right):
> 
>
https://codereview.chromium.org/1018523007/diff/1/chrome/browser/chromeos/log...
> chrome/browser/chromeos/login/screens/update_screen.cc:72: const int
> kDelayErrorMessageSec = 10;
> On 2015/03/24 11:41:35, Nikita Kostylev wrote:
> > On 2015/03/20 12:04:58, Denis Kuznetsov wrote:
> > > I believe that 10 seconds can be too much here. Have you clarified this
> > number?
> > 
> > As discussed, OK to use this timeout + add UMA metric.
> 
> Done.

I'm removing myself from reviewers.
Denis, please review.

[Nikita (slow), 2015-03-24 14:34:29]

nkostylev@chromium.org changed reviewers:
- antrim@chromium.org

[Nikita (slow), 2015-03-24 14:34:46]

nkostylev@chromium.org changed reviewers:
+ antrim@chromium.org
- nkostylev@chromium.org

[Denis Kuznetsov (DE-MUC), 2015-03-24 17:21:05]

lgtm

[Ilya Sherman, 2015-03-24 18:18:36]

LGTM % nits:

https://codereview.chromium.org/1018523007/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc (right):

https://codereview.chromium.org/1018523007/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc:98:
started_loading_at_ = base::Time::FromInternalValue(0);
nit: Why not "base::Time()"?

https://codereview.chromium.org/1018523007/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1018523007/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2300: +    Number of milliseconds passed
before captive portal performs redirect
Please document what the start time is.

https://codereview.chromium.org/1018523007/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2300: +    Number of milliseconds passed
before captive portal performs redirect
nit: "passed" - "elapsed"

https://codereview.chromium.org/1018523007/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2300: +    Number of milliseconds passed
before captive portal performs redirect
nit: Please end the sentence with a period.

[Alexander Alekseev, 2015-03-25 13:05:24]

https://codereview.chromium.org/1018523007/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc (right):

https://codereview.chromium.org/1018523007/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc:98:
started_loading_at_ = base::Time::FromInternalValue(0);
On 2015/03/24 18:18:35, Ilya Sherman wrote:
> nit: Why not "base::Time()"?

Done.

https://codereview.chromium.org/1018523007/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1018523007/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2300: +    Number of milliseconds passed
before captive portal performs redirect
On 2015/03/24 18:18:35, Ilya Sherman wrote:
> Please document what the start time is.

Done.

https://codereview.chromium.org/1018523007/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2300: +    Number of milliseconds passed
before captive portal performs redirect
On 2015/03/24 18:18:35, Ilya Sherman wrote:
> nit: "passed" - "elapsed"

Done.

https://codereview.chromium.org/1018523007/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2300: +    Number of milliseconds passed
before captive portal performs redirect
On 2015/03/24 18:18:36, Ilya Sherman wrote:
> nit: Please end the sentence with a period.

Done.

[Alexander Alekseev, 2015-03-25 13:05:30]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2015-03-25 13:05:30]

The patchset sent to the CQ was uploaded after l-g-t-m from antrim@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1018523007/#ps40001
(title: "Update after review.")

[commit-bot: I haz the power, 2015-03-25 13:05:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1018523007/40001

[commit-bot: I haz the power, 2015-03-25 14:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 14:22:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2015-03-25 18:51:05]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2015-03-25 18:51:05]

The patchset sent to the CQ was uploaded after l-g-t-m from antrim@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1018523007/#ps60001
(title: "Fixed browser tests.")

[commit-bot: I haz the power, 2015-03-25 18:51:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1018523007/60001

[commit-bot: I haz the power, 2015-03-25 20:24:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-25 20:25:14]

Patchset 4 (id:??) landed as
https://crrev.com/bcb37a14572ef5c7f13a6bc75e4a4b65cabb9ec7
Cr-Commit-Position: refs/heads/master@{#322230}