Invalidate DisplayItemClient when selection state changes

Invalidate DisplayItemClient when selection state changes

Selection state affects whether selection highlight should be painted
during the foreground phase, thus the object should be re-recorded.

BUG=463608
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192135

[trchen, 2015-03-18 03:23:27]

trchen@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2015-03-18 16:10:07]

https://codereview.chromium.org/1018503004/diff/1/Source/core/layout/LayoutOb...
File Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/1018503004/diff/1/Source/core/layout/LayoutOb...
Source/core/layout/LayoutObject.cpp:3024:
invalidateDisplayItemClient(DisplayItemClientData(*this));
Alternative way is to call 'if slimmingPaintEnabled)
setShouldDoFullPaintInvalidation()' here. I prefer it because it's faster.
invalidateDisplayItemClient involves walking up the layout tree to find paint
invalidation container.

[trchen, 2015-03-18 22:59:05]

Revised as discussed offline & updating test expectation.

[Xianzhu, 2015-03-18 23:21:29]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-03-18 23:21:29]

lgtm

[commit-bot: I haz the power, 2015-03-18 23:24:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1018503004/20001

[trchen, 2015-03-19 00:47:31]

The CQ bit was checked by trchen@chromium.org

[trchen, 2015-03-19 00:47:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/1018503004/#ps40001
(title: "+1 missing expectation")

[commit-bot: I haz the power, 2015-03-19 00:47:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1018503004/40001

[commit-bot: I haz the power, 2015-03-19 04:06:28]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192135