Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: chrome/renderer/resources/extensions/developer_private_custom_bindings.js

Issue 1018493002: [Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/extensions/api/developer_private.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the developerPrivate API. 5 // Custom binding for the developerPrivate API.
6 6
7 var binding = require('binding').Binding.create('developerPrivate'); 7 var binding = require('binding').Binding.create('developerPrivate');
8 8
9 binding.registerCustomHook(function(bindingsAPI) { 9 binding.registerCustomHook(function(bindingsAPI) {
10 var apiFunctions = bindingsAPI.apiFunctions; 10 var apiFunctions = bindingsAPI.apiFunctions;
11 11
12 // Converts the argument of |functionName| from DirectoryEntry to URL. 12 // Converts the argument of |functionName| from DirectoryEntry to URL.
13 function bindFileSystemFunction(functionName) { 13 function bindFileSystemFunction(functionName) {
14 apiFunctions.setUpdateArgumentsPostValidate( 14 apiFunctions.setUpdateArgumentsPostValidate(
15 functionName, function(directoryEntry, callback) { 15 functionName, function(directoryEntry, callback) {
16 var fileSystemName = directoryEntry.filesystem.name; 16 var fileSystemName = directoryEntry.filesystem.name;
17 var relativePath = $String.slice(directoryEntry.fullPath, 1); 17 var relativePath = $String.slice(directoryEntry.fullPath, 1);
18 var url = directoryEntry.toURL(); 18 var url = directoryEntry.toURL();
19 return [fileSystemName, relativePath, url, callback]; 19 return [fileSystemName, relativePath, url, callback];
20 }); 20 });
21 } 21 }
22 22
23 bindFileSystemFunction('loadDirectory'); 23 bindFileSystemFunction('loadDirectory');
24 24
25 // developerPrivate.enable is the same as chrome.management.setEnabled. 25 // developerPrivate.enable is the same as chrome.management.setEnabled.
26 // TODO(devlin): Migrate callers off developerPrivate.enable. 26 // TODO(devlin): Migrate callers off developerPrivate.enable.
27 bindingsAPI.compiledApi.enable = chrome.management.setEnabled; 27 bindingsAPI.compiledApi.enable = chrome.management.setEnabled;
28 28
29 bindingsAPI.compiledApi.allowFileAccess = function(id, allow, callback) { 29 apiFunctions.setHandleRequest('allowFileAccess',
30 function(id, allow, callback) {
30 chrome.developerPrivate.updateExtensionConfiguration( 31 chrome.developerPrivate.updateExtensionConfiguration(
31 {extensionId: id, fileAccess: allow}, callback); 32 {extensionId: id, fileAccess: allow}, callback);
32 }; 33 });
33 34
34 bindingsAPI.compiledApi.allowIncognito = function(id, allow, callback) { 35 apiFunctions.setHandleRequest('allowIncognito',
36 function(id, allow, callback) {
35 chrome.developerPrivate.updateExtensionConfiguration( 37 chrome.developerPrivate.updateExtensionConfiguration(
36 {extensionId: id, incognitoAccess: allow}, callback); 38 {extensionId: id, incognitoAccess: allow}, callback);
37 }; 39 });
40
41 apiFunctions.setHandleRequest('inspect', function(options, callback) {
42 var renderViewId = options.render_view_id;
43 if (typeof renderViewId == 'string') {
44 renderViewId = parseInt(renderViewId);
45 if (isNaN(renderViewId))
46 throw new Error('Invalid value for render_view_id');
47 }
48 var renderProcessId = options.render_process_id;
49 if (typeof renderProcessId == 'string') {
50 renderProcessId = parseInt(renderProcessId);
51 if (isNaN(renderProcessId))
52 throw new Error('Invalid value for render_process_id');
53 }
54 chrome.developerPrivate.openDevTools({
55 extensionId: options.extension_id,
56 renderProcessId: renderProcessId,
57 renderViewId: renderViewId,
58 incognito: options.incognito
59 }, callback);
60 });
38 }); 61 });
39 62
40 exports.binding = binding.generate(); 63 exports.binding = binding.generate();
OLDNEW
« no previous file with comments | « chrome/common/extensions/api/developer_private.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698