Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 1018493002: [Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="extension_error.js"> 5 <include src="extension_error.js">
6 6
7 /////////////////////////////////////////////////////////////////////////////// 7 ///////////////////////////////////////////////////////////////////////////////
8 // ExtensionFocusRow: 8 // ExtensionFocusRow:
9 9
10 /** 10 /**
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 } else { 752 } else {
753 displayName = view.url; 753 displayName = view.url;
754 } 754 }
755 var label = displayName + 755 var label = displayName +
756 (view.incognito ? 756 (view.incognito ?
757 ' ' + loadTimeData.getString('viewIncognito') : '') + 757 ' ' + loadTimeData.getString('viewIncognito') : '') +
758 (view.renderProcessId == -1 ? 758 (view.renderProcessId == -1 ?
759 ' ' + loadTimeData.getString('viewInactive') : ''); 759 ' ' + loadTimeData.getString('viewInactive') : '');
760 link.textContent = label; 760 link.textContent = label;
761 link.clickHandler = function(e) { 761 link.clickHandler = function(e) {
762 chrome.developerPrivate.inspect({ 762 chrome.developerPrivate.openDevTools({
763 extension_id: extension.id, 763 extensionId: extension.id,
764 render_process_id: view.renderProcessId, 764 renderProcessId: view.renderProcessId,
765 render_view_id: view.renderViewId, 765 renderViewId: view.renderViewId,
766 incognito: view.incognito 766 incognito: view.incognito
767 }); 767 });
768 }; 768 };
769 link.addEventListener('click', link.clickHandler); 769 link.addEventListener('click', link.clickHandler);
770 770
771 if (i < extension.views.length - 1) { 771 if (i < extension.views.length - 1) {
772 link = link.cloneNode(true); 772 link = link.cloneNode(true);
773 item.appendChild(link); 773 item.appendChild(link);
774 } 774 }
775 }); 775 });
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 // TODO(dbeam): why do we need to focus <extensionoptions> before and 940 // TODO(dbeam): why do we need to focus <extensionoptions> before and
941 // after its showing animation? Makes very little sense to me. 941 // after its showing animation? Makes very little sense to me.
942 overlay.setInitialFocus(); 942 overlay.setInitialFocus();
943 }, 943 },
944 }; 944 };
945 945
946 return { 946 return {
947 ExtensionList: ExtensionList 947 ExtensionList: ExtensionList
948 }; 948 };
949 }); 949 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698