[Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools

chrome/renderer/resources/extensions/developer_private_custom_bindings.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom binding for the developerPrivate API.
 
 var binding = require('binding').Binding.create('developerPrivate');
 
 binding.registerCustomHook(function(bindingsAPI) {
   var apiFunctions = bindingsAPI.apiFunctions;
 
   // Converts the argument of |functionName| from DirectoryEntry to URL.
   function bindFileSystemFunction(functionName) {
     apiFunctions.setUpdateArgumentsPostValidate(
         functionName, function(directoryEntry, callback) {
           var fileSystemName = directoryEntry.filesystem.name;
           var relativePath = $String.slice(directoryEntry.fullPath, 1);
           var url = directoryEntry.toURL();
           return [fileSystemName, relativePath, url, callback];
     });
   }
 
   bindFileSystemFunction('loadDirectory');
 
   // developerPrivate.enable is the same as chrome.management.setEnabled.
   // TODO(devlin): Migrate callers off developerPrivate.enable.
   bindingsAPI.compiledApi.enable = chrome.management.setEnabled;
+
+  bindingsAPI.compiledApi.inspect = function(options, callback) {

[not at google - send to devlin, 2015/03/19 18:52:49]

In this case you might be better off using setHandleRequest('inspect') which
does argument normalization and parsing for you. Maybe. It all just looks more
hands-on that I would have expected to be necessary.

[Devlin, 2015/03/19 20:27:33]

Well, setHandleRequest looks like the right thing to use (also for
'allowFileAccess' and 'allowIncognito').  Unfortunately, it doesn't really help
with the hands-on part, because we need to handle the case of string values for
ids (since that what the API started as).

The downside is now we need to keep the definitions in the idl file, but that's
probably worth it for the errors and typesafety from the autogenerated bindings.

+    var renderViewId = options.render_view_id;
+    if (typeof(renderViewId) == 'string') {

[not at google - send to devlin, 2015/03/19 18:52:49]

typeof is a keyword not a function

[Devlin, 2015/03/19 20:27:33]

Huh. Never knew (obviously works fine when called typeof(foo).  Done.

+      renderViewId = parseInt(renderViewId);
+      if (isNaN(renderViewId))
+        throw new Error('Invalid value for render_view_id');
+    }
+    var renderProcessId = options.render_process_id;
+    if (typeof(renderProcessId) == 'string') {
+      renderProcessId = parseInt(renderProcessId);
+      if (isNaN(renderProcessId))
+        throw new Error('Invalid value for render_process_id');
+    }
+    chrome.developerPrivate.openDevTools({
+        extensionId: options.extension_id,
+        renderProcessId: renderProcessId,
+        renderViewId: renderViewId,
+        incognito: options.incognito
+    }, callback);
+  };
 });
 
 exports.binding = binding.generate();