Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 1018493002: [Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="extension_error.js"> 5 <include src="extension_error.js">
6 6
7 /////////////////////////////////////////////////////////////////////////////// 7 ///////////////////////////////////////////////////////////////////////////////
8 // ExtensionFocusRow: 8 // ExtensionFocusRow:
9 9
10 /** 10 /**
(...skipping 716 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 } else { 727 } else {
728 displayName = view.url; 728 displayName = view.url;
729 } 729 }
730 var label = displayName + 730 var label = displayName +
731 (view.incognito ? 731 (view.incognito ?
732 ' ' + loadTimeData.getString('viewIncognito') : '') + 732 ' ' + loadTimeData.getString('viewIncognito') : '') +
733 (view.renderProcessId == -1 ? 733 (view.renderProcessId == -1 ?
734 ' ' + loadTimeData.getString('viewInactive') : ''); 734 ' ' + loadTimeData.getString('viewInactive') : '');
735 link.textContent = label; 735 link.textContent = label;
736 link.clickHandler = function(e) { 736 link.clickHandler = function(e) {
737 chrome.developerPrivate.inspect({ 737 chrome.developerPrivate.openDevTools({
738 extension_id: extension.id, 738 extensionId: extension.id,
739 render_process_id: view.renderProcessId, 739 renderProcessId: view.renderProcessId,
740 render_view_id: view.renderViewId, 740 renderViewId: view.renderViewId,
741 incognito: view.incognito 741 incognito: view.incognito
742 }); 742 });
743 }; 743 };
744 link.addEventListener('click', link.clickHandler); 744 link.addEventListener('click', link.clickHandler);
745 745
746 if (i < extension.views.length - 1) { 746 if (i < extension.views.length - 1) {
747 link = link.cloneNode(true); 747 link = link.cloneNode(true);
748 item.appendChild(link); 748 item.appendChild(link);
749 } 749 }
750 }); 750 });
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 // TODO(dbeam): why do we need to focus <extensionoptions> before and 914 // TODO(dbeam): why do we need to focus <extensionoptions> before and
915 // after its showing animation? Makes very little sense to me. 915 // after its showing animation? Makes very little sense to me.
916 overlay.setInitialFocus(); 916 overlay.setInitialFocus();
917 }, 917 },
918 }; 918 };
919 919
920 return { 920 return {
921 ExtensionList: ExtensionList 921 ExtensionList: ExtensionList
922 }; 922 };
923 }); 923 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698