Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 1018463005: cc: PushProperties on viewport size change (Closed)

Created:
5 years, 9 months ago by hendrikw
Modified:
5 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: PushProperties on viewport size change When we are using GPU rasterization, tile size is based on the viewport width. We could have layers that change in size, but are not invalidated because no layout is required. When this happens, we need to notify the layers that they require a PushProperties to resize the tiles correctly. Also added a test. BUG=458750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M cc/layers/layer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
hendrikw
PTAL, thanks.
5 years, 9 months ago (2015-03-16 21:10:34 UTC) #2
hendrikw
5 years, 9 months ago (2015-03-16 21:50:33 UTC) #3
On 2015/03/16 21:10:34, hendrikw wrote:
> PTAL, thanks.

Hold off for a sec on this review please.

Powered by Google App Engine
This is Rietveld 408576698