Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1018463002: Deprecate WinSAT support in Chromium. (Closed)

Created:
5 years, 9 months ago by Zhenyao Mo
Modified:
5 years, 9 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, estade+watch_chromium.org, jam, Justin Novosad, piman+watch_chromium.org, rouslan+autofillwatch_chromium.org, Vangelis Kokkevis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate WinSAT support in Chromium. BUG=456004 TEST=gpu_unittests, about:gpu page R=kbr@chromium.org Committed: https://crrev.com/7bc34f43f0c06e849031bab4abaada1e08ea2037 Cr-Commit-Position: refs/heads/master@{#320942}

Patch Set 1 #

Patch Set 2 : fix gpu_unittests #

Total comments: 2

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -324 lines) Patch
M components/autofill/content/browser/risk/fingerprint.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/autofill/content/browser/risk/proto/fingerprint.proto View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M components/metrics/gpu/gpu_metrics_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/metrics/proto/system_profile.proto View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/resources/gpu/info_view.html View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/resources/gpu/info_view.js View 2 chunks +0 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 2 chunks +0 lines, -7 lines 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/gpu_blacklist_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_control_list.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M gpu/config/gpu_control_list_entry_unittest.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M gpu/config/gpu_control_list_format.txt View 1 chunk +12 lines, -15 lines 0 comments Download
M gpu/config/gpu_control_list_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_info.h View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/config/gpu_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 2 chunks +0 lines, -112 lines 0 comments Download
D gpu/config/gpu_performance_stats.h View 1 chunk +0 lines, -23 lines 0 comments Download
M gpu/config/software_rendering_list_json.cc View 2 chunks +1 line, -27 lines 0 comments Download
M gpu/gpu_config.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
Zhenyao Mo
kbr: please review. caitkp: component/ owner. dcheng: gcontent/common/gpu/gpu_messages.h security review sievers: gpu/ owner
5 years, 9 months ago (2015-03-16 20:14:53 UTC) #3
Zhenyao Mo
5 years, 9 months ago (2015-03-16 20:15:09 UTC) #4
no sievers
gpu lgtm https://codereview.chromium.org/1018463002/diff/20001/gpu/config/gpu_info_collector_win.cc File gpu/config/gpu_info_collector_win.cc (left): https://codereview.chromium.org/1018463002/diff/20001/gpu/config/gpu_info_collector_win.cc#oldcode159 gpu/config/gpu_info_collector_win.cc:159: "GPU.WinSAT.OverallScore2", Does anything else need to be ...
5 years, 9 months ago (2015-03-16 20:38:45 UTC) #5
Zhenyao Mo
https://codereview.chromium.org/1018463002/diff/20001/gpu/config/gpu_info_collector_win.cc File gpu/config/gpu_info_collector_win.cc (left): https://codereview.chromium.org/1018463002/diff/20001/gpu/config/gpu_info_collector_win.cc#oldcode159 gpu/config/gpu_info_collector_win.cc:159: "GPU.WinSAT.OverallScore2", On 2015/03/16 20:38:45, sievers wrote: > Does anything ...
5 years, 9 months ago (2015-03-16 21:10:29 UTC) #6
Ken Russell (switch to Gerrit)
LGTM. junov: FYI.
5 years, 9 months ago (2015-03-16 22:22:27 UTC) #7
dcheng
rs lgtm for deletions in gpu_messages.h.
5 years, 9 months ago (2015-03-17 01:49:44 UTC) #8
Cait (Slow)
Should these be removed from the autofill fingerprint.proto as well?: https://code.google.com/p/chromium/codesearch#chromium/src/components/autofill/content/browser/risk/proto/fingerprint.proto&l=56
5 years, 9 months ago (2015-03-17 15:40:41 UTC) #9
Zhenyao Mo
On 2015/03/17 15:40:41, Cait wrote: > Should these be removed from the autofill fingerprint.proto as ...
5 years, 9 months ago (2015-03-17 16:23:31 UTC) #10
Cait (Slow)
components/ lgtm
5 years, 9 months ago (2015-03-17 17:01:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018463002/40001
5 years, 9 months ago (2015-03-17 17:06:30 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 18:09:16 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:10:47 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7bc34f43f0c06e849031bab4abaada1e08ea2037
Cr-Commit-Position: refs/heads/master@{#320942}

Powered by Google App Engine
This is Rietveld 408576698