Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1018443002: Revert of Disable a test that fails under ASan and MSan (Closed)

Created:
5 years, 9 months ago by nasko
Modified:
5 years, 9 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable a test that fails under ASan and MSan (patchset #1 id:1 of https://codereview.chromium.org/1007293002/) Reason for revert: This test is a victim of a bigger issue of main renderer message loop being used after it is deleted. Details are in crbug.com/467369. I've also run the test with ASAN locally and didn't reproduce after a few runs. Original issue's description: > Disable a test that fails under ASan and MSan > > It can be flaky in other configurations as well > > BUG=467483 > TBR=nasko > > Committed: https://crrev.com/992ff715f61e90562983139ac31392b72e716822 > Cr-Commit-Position: refs/heads/master@{#320713} TBR=timurrrr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467483 Committed: https://crrev.com/216981c97018a8b8dea097cbde58889bf4e68c1a Cr-Commit-Position: refs/heads/master@{#320755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nasko
Created Revert of Disable a test that fails under ASan and MSan
5 years, 9 months ago (2015-03-16 18:23:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018443002/1
5 years, 9 months ago (2015-03-16 18:23:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 18:24:56 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/216981c97018a8b8dea097cbde58889bf4e68c1a Cr-Commit-Position: refs/heads/master@{#320755}
5 years, 9 months ago (2015-03-16 18:25:43 UTC) #4
Timur Iskhodzhanov
Don't approve. [And I don't think this should have been TBR'ed] We should not reenable ...
5 years, 9 months ago (2015-03-17 10:55:24 UTC) #5
Timur Iskhodzhanov
5 years, 9 months ago (2015-03-17 10:56:10 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1011083002/ by timurrrr@chromium.org.

The reason for reverting is: The underlying issue is still not fixed,
re-enabling the test causes bots to turn red.

Please wait for the underlying issue to be resolved before re-enabling..

Powered by Google App Engine
This is Rietveld 408576698