Convert video capture pipline to base::TimeTicks

Convert video capture pipline to base::TimeTicks

base::TimeTicks is a monotonic clock, unlike base::Time, which may change if
the system time is changed.  Switch over the video capture pipeline to use this
clock.

BUG=249215
TEST=local build, run on CrOS snow, desktop Linux

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243493

[sheu, 2014-01-06 21:37:42]

miu@: this bug was assigned to you, but I got to it first.  PTAL :-)

[miu, 2014-01-06 22:39:36]

Looks great!  Thanks for taking care of all this.  Just a couple of small
things...

https://chromiumcodereview.appspot.com/101843005/diff/1/content/renderer/medi...
File content/renderer/media/video_capture_impl.cc (right):

https://chromiumcodereview.appspot.com/101843005/diff/1/content/renderer/medi...
content/renderer/media/video_capture_impl.cc:270: timestamp -
last_frame_timestamp_,
Nice and clean!  :-)  I like how the first frame has a TimeDelta value of zero,
and then is monotonically non-decreasing from there.

https://chromiumcodereview.appspot.com/101843005/diff/1/content/renderer/medi...
File content/renderer/media/video_capture_impl.h (right):

https://chromiumcodereview.appspot.com/101843005/diff/1/content/renderer/medi...
content/renderer/media/video_capture_impl.h:144: base::TimeTicks
last_frame_timestamp_;
This comment and member name are wrong.  This looks like a
"first_frame_timestamp_" instead.  No gripes with your approach here--I like
what you've done--just the naming/comment need to reflect that this is the
timestamp of the first frame and used to compute monotonically non-decreasing
frame time deltas.

https://chromiumcodereview.appspot.com/101843005/diff/1/media/video/capture/a...
File media/video/capture/android/video_capture_device_android.cc (right):

https://chromiumcodereview.appspot.com/101843005/diff/1/media/video/capture/a...
media/video/capture/android/video_capture_device_android.cc:225:
base::TimeStamp::Now(),
I think you meant base::TimeTicks here.

[sheu, 2014-01-06 22:52:36]

Done!  miu@: PTAL

https://chromiumcodereview.appspot.com/101843005/diff/1/content/renderer/medi...
File content/renderer/media/video_capture_impl.h (right):

https://chromiumcodereview.appspot.com/101843005/diff/1/content/renderer/medi...
content/renderer/media/video_capture_impl.h:144: base::TimeTicks
last_frame_timestamp_;
On 2014/01/06 22:39:37, miu wrote:
> This comment and member name are wrong.  This looks like a
> "first_frame_timestamp_" instead.  No gripes with your approach here--I like
> what you've done--just the naming/comment need to reflect that this is the
> timestamp of the first frame and used to compute monotonically non-decreasing
> frame time deltas.

Heh yeah.  I was not really paying enough attention here :-)

https://chromiumcodereview.appspot.com/101843005/diff/1/media/video/capture/a...
File media/video/capture/android/video_capture_device_android.cc (right):

https://chromiumcodereview.appspot.com/101843005/diff/1/media/video/capture/a...
media/video/capture/android/video_capture_device_android.cc:225:
base::TimeStamp::Now(),
On 2014/01/06 22:39:37, miu wrote:
> I think you meant base::TimeTicks here.

Done.

[miu, 2014-01-06 22:55:58]

lgtm

[sheu, 2014-01-06 22:57:02]

Adding more OWNERs now.  wjia@: PTAL.

[wjia(left Chromium), 2014-01-07 00:11:14]

lgtm. Thanks for doing this!

[sheu, 2014-01-07 00:17:46]

Two OWNERS bits left.

cevans@: trivial IPC check on content/common/media/video_capture_messages.h
jam@: fairly trivial in:
content/browser/renderer_host/render_widget_host_view_aura.cc
content/browser/renderer_host/render_widget_host_view_browsertest.cc
content/port/browser/render_widget_host_view_frame_subscriber.h

Thanks!

[sheu, 2014-01-07 00:18:32]

cevans@: PTAL at content/common/media/video_capture_messages.h

[jam, 2014-01-07 21:09:05]

lgtm

[Chris Evans, 2014-01-07 21:16:04]

On 2014/01/07 21:09:05, jam wrote:
> lgtm

LGTM

[commit-bot: I haz the power, 2014-01-07 21:18:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheu@chromium.org/101843005/280001

[commit-bot: I haz the power, 2014-01-07 21:58:31]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-07 22:11:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheu@chromium.org/101843005/630001

[commit-bot: I haz the power, 2014-01-08 01:07:20]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 01:11:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheu@chromium.org/101843005/630001

[commit-bot: I haz the power, 2014-01-08 06:15:48]

Change committed as 243493