Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 101843002: Tests that make a stack allocated persistent weak and rely on gc need to force gc (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)
Modified:
7 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Tests that make a stack allocated persistent weak and rely on gc need to force gc Otherwise, if during a fuzzer test incremental marking is running, we'll crash in the weak callback BUG=none TBR=verwaest@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/cctest/test-api.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
7 years ago (2013-12-03 13:10:06 UTC) #1
jochen (gone - plz use gerrit)
7 years ago (2013-12-03 13:12:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r18233 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698