Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: content/renderer/java/gin_java_bridge_object.h

Issue 1018413002: [Android] Fix method invocation and wrappers cleanup handling in Java Bridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a dedicated test for attempting to call a non-existing method via `call` Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/java/gin_java_bridge_object.h
diff --git a/content/renderer/java/gin_java_bridge_object.h b/content/renderer/java/gin_java_bridge_object.h
index e119c88e311166f6a862a76cd7bef37f75c18022..da7460f9c8710b74cf3443f6c2a96e17905ad978 100644
--- a/content/renderer/java/gin_java_bridge_object.h
+++ b/content/renderer/java/gin_java_bridge_object.h
@@ -7,7 +7,6 @@
#include <map>
-#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "content/renderer/java/gin_java_bridge_dispatcher.h"
#include "gin/handle.h"
@@ -22,8 +21,6 @@ class WebFrame;
namespace content {
-class GinJavaBridgeValueConverter;
-
class GinJavaBridgeObject : public gin::Wrappable<GinJavaBridgeObject>,
public gin::NamedPropertyInterceptor {
public:
@@ -58,12 +55,9 @@ class GinJavaBridgeObject : public gin::Wrappable<GinJavaBridgeObject>,
v8::Local<v8::FunctionTemplate> GetFunctionTemplate(v8::Isolate* isolate,
const std::string& name);
- v8::Handle<v8::Value> InvokeMethod(const std::string& name,
- gin::Arguments* args);
base::WeakPtr<GinJavaBridgeDispatcher> dispatcher_;
GinJavaBridgeDispatcher::ObjectID object_id_;
- scoped_ptr<GinJavaBridgeValueConverter> converter_;
std::map<std::string, bool> known_methods_;
v8::StdPersistentValueMap<std::string, v8::FunctionTemplate> template_cache_;
« no previous file with comments | « content/renderer/java/gin_java_bridge_dispatcher.cc ('k') | content/renderer/java/gin_java_bridge_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698