Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: content/renderer/java/gin_java_function_invocation_helper.cc

Issue 1018413002: [Android] Fix method invocation and wrappers cleanup handling in Java Bridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a dedicated test for attempting to call a non-existing method via `call` Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/java/gin_java_function_invocation_helper.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/renderer/java/gin_java_function_invocation_helper.h"
6
7 #include "content/common/android/gin_java_bridge_errors.h"
8 #include "content/common/android/gin_java_bridge_value.h"
9 #include "content/public/child/v8_value_converter.h"
10 #include "content/renderer/java/gin_java_bridge_object.h"
11 #include "content/renderer/java/gin_java_bridge_value_converter.h"
12
13 namespace content {
14
15 namespace {
16
17 const char kMethodInvocationAsConstructorDisallowed[] =
18 "Java bridge method can't be invoked as a constructor";
19 const char kMethodInvocationOnNonInjectedObjectDisallowed[] =
20 "Java bridge method can't be invoked on a non-injected object";
21 const char kMethodInvocationErrorMessage[] =
22 "Java bridge method invocation error";
23
24 } // namespace
25
26 GinJavaFunctionInvocationHelper::GinJavaFunctionInvocationHelper(
27 const std::string& method_name,
28 const base::WeakPtr<GinJavaBridgeDispatcher>& dispatcher)
29 : method_name_(method_name),
30 dispatcher_(dispatcher),
31 converter_(new GinJavaBridgeValueConverter()) {
32 }
33
34 GinJavaFunctionInvocationHelper::~GinJavaFunctionInvocationHelper() {
35 }
36
37 v8::Handle<v8::Value> GinJavaFunctionInvocationHelper::Invoke(
38 gin::Arguments* args) {
39 if (!dispatcher_) {
40 args->isolate()->ThrowException(v8::Exception::Error(gin::StringToV8(
41 args->isolate(), kMethodInvocationErrorMessage)));
42 return v8::Undefined(args->isolate());
43 }
44
45 if (args->IsConstructCall()) {
46 args->isolate()->ThrowException(v8::Exception::Error(gin::StringToV8(
47 args->isolate(), kMethodInvocationAsConstructorDisallowed)));
48 return v8::Undefined(args->isolate());
49 }
50
51 content::GinJavaBridgeObject* object = NULL;
52 if (!args->GetHolder(&object) || !object) {
53 args->isolate()->ThrowException(v8::Exception::Error(gin::StringToV8(
54 args->isolate(), kMethodInvocationOnNonInjectedObjectDisallowed)));
55 return v8::Undefined(args->isolate());
56 }
57
58 base::ListValue arguments;
59 {
60 v8::HandleScope handle_scope(args->isolate());
61 v8::Handle<v8::Context> context = args->isolate()->GetCurrentContext();
62 v8::Handle<v8::Value> val;
63 while (args->GetNext(&val)) {
64 scoped_ptr<base::Value> arg(converter_->FromV8Value(val, context));
65 if (arg.get()) {
66 arguments.Append(arg.release());
67 } else {
68 arguments.Append(base::Value::CreateNullValue());
69 }
70 }
71 }
72
73 GinJavaBridgeError error;
74 scoped_ptr<base::Value> result = dispatcher_->InvokeJavaMethod(
75 object->object_id(), method_name_, arguments, &error);
76 if (!result.get()) {
77 args->isolate()->ThrowException(v8::Exception::Error(gin::StringToV8(
78 args->isolate(), GinJavaBridgeErrorToString(error))));
79 return v8::Undefined(args->isolate());
80 }
81 if (!result->IsType(base::Value::TYPE_BINARY)) {
82 return converter_->ToV8Value(result.get(),
83 args->isolate()->GetCurrentContext());
84 }
85
86 scoped_ptr<const GinJavaBridgeValue> gin_value =
87 GinJavaBridgeValue::FromValue(result.get());
88 if (gin_value->IsType(GinJavaBridgeValue::TYPE_OBJECT_ID)) {
89 GinJavaBridgeObject* result = NULL;
90 GinJavaBridgeDispatcher::ObjectID object_id;
91 if (gin_value->GetAsObjectID(&object_id)) {
92 result = dispatcher_->GetObject(object_id);
93 }
94 if (result) {
95 gin::Handle<GinJavaBridgeObject> controller =
96 gin::CreateHandle(args->isolate(), result);
97 if (controller.IsEmpty())
98 return v8::Undefined(args->isolate());
99 return controller.ToV8();
100 }
101 } else if (gin_value->IsType(GinJavaBridgeValue::TYPE_NONFINITE)) {
102 float float_value;
103 gin_value->GetAsNonFinite(&float_value);
104 return v8::Number::New(args->isolate(), float_value);
105 }
106 return v8::Undefined(args->isolate());
107 }
108
109 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/java/gin_java_function_invocation_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698