Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart

Issue 1018403002: Revert "Use an explicit 'this' parameter instead of 'This' nodes." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/backend_dart/sexpr_test.dart ('k') | tests/language/parameter_initializer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart
diff --git a/tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart b/tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart
index 1f06307f1fe54b0dff42421870d1c00dbf8374ce..3c982c744a704b6bc2c9d7301a6df76c47c8d9d3 100644
--- a/tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart
+++ b/tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart
@@ -87,17 +87,7 @@ class Tokens {
String read([String expected]) {
if (expected != null) {
- if (current != expected) {
- print('expected "$expected", found "$current"');
- int start = _index - 15;
- String dotdotdot = '... ';
- if (start < 0) {
- start = 0;
- dotdotdot = '';
- }
- print('${dotdotdot}${_list.sublist(start, _index + 1).join(' ')}');
- assert(current == expected);
- }
+ assert(current == expected);
}
return _list[_index++];
}
@@ -278,20 +268,6 @@ class SExpressionUnstringifier {
element = new DummyElement(tokens.read());
}
- // (this) or ()
- Definition thisParameter = null;
- tokens.consumeStart();
- if (tokens.current != ')') {
- String thisName = tokens.read();
- if (name2variable.containsKey(thisName)) {
- thisParameter = name2variable[thisName];
- } else {
- thisParameter = new Parameter(new DummyElement(thisName));
- name2variable[thisName] = thisParameter;
- }
- }
- tokens.consumeEnd();
-
// (parameters)
List<Definition> parameters = <Definition>[];
tokens.consumeStart();
@@ -316,7 +292,7 @@ class SExpressionUnstringifier {
Expression body = parseExpression();
tokens.consumeEnd();
- return new FunctionDefinition(element, thisParameter, parameters,
+ return new FunctionDefinition(element, parameters,
new RunnableBody(body, cont), null, null);
}
« no previous file with comments | « tests/compiler/dart2js/backend_dart/sexpr_test.dart ('k') | tests/language/parameter_initializer_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698