Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: native_client_sdk/src/tests/nacl_io_test/path_test.cc

Issue 1018393007: [NaCl SDK] nacl_io: Fix bug in Path::Range introduced in recent change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add additional tests for values completely outside the range Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/path.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tests/nacl_io_test/path_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/path_test.cc b/native_client_sdk/src/tests/nacl_io_test/path_test.cc
index b7b82cc636185fa6c041c032cb38f524a050ecab..77160676202549f251036e48edfb78f851d63f8f 100644
--- a/native_client_sdk/src/tests/nacl_io_test/path_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/path_test.cc
@@ -70,6 +70,7 @@ TEST(PathTest, OnePart_Absolute) {
EXPECT_EQ("/", p.Range(0, 1));
EXPECT_EQ("foo", p.Range(1, 2));
EXPECT_EQ("/foo", p.Range(0, 2));
+ EXPECT_EQ("", p.Range(2, 2));
EXPECT_EQ("/", p.Parent().Join());
}
@@ -85,6 +86,7 @@ TEST(PathTest, TwoPart_Relative) {
EXPECT_EQ("foo", p.Range(0, 1));
EXPECT_EQ("bar", p.Range(1, 2));
EXPECT_EQ("foo/bar", p.Range(0, 2));
+ EXPECT_EQ("", p.Range(2, 2));
EXPECT_EQ("foo", p.Parent().Join());
}
@@ -185,6 +187,9 @@ TEST(PathTest, Range_Relative) {
EXPECT_EQ("relative/path", p.Range(1, 3));
EXPECT_EQ("path", p.Range(2, 3));
+
+ EXPECT_EQ("", p.Range(2, 100));
+ EXPECT_EQ("", p.Range(42, 67));
}
TEST(PathTest, Range_Absolute) {
@@ -203,6 +208,9 @@ TEST(PathTest, Range_Absolute) {
EXPECT_EQ("absolute/path", p.Range(2, 4));
EXPECT_EQ("path", p.Range(3, 4));
+
+ EXPECT_EQ("", p.Range(2, 100));
+ EXPECT_EQ("", p.Range(42, 67));
}
TEST(PathTest, Assign) {
« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/path.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698