Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1018393007: [NaCl SDK] nacl_io: Fix bug in Path::Range introduced in recent change. (Closed)

Created:
5 years, 9 months ago by binji
Modified:
5 years, 9 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Fix bug in Path::Range introduced in recent change. Path("foo/bar") has 2 components "foo" and "bar". It is legal when calling Path::Range to access an invalid component (e.g. Path("foo/bar").Range(2, 2). In this case, the previous STL-based implementation would return "", but my non-STL implementation was incorrectly returning "foo/bar". BUG=none R=sbc@chromium.org Committed: https://crrev.com/def60c001d10a9d70b7b8b4d8f8143a88bad81f5 Cr-Commit-Position: refs/heads/master@{#322035}

Patch Set 1 #

Patch Set 2 : remove unnecessary test #

Patch Set 3 : add additional tests for values completely outside the range #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M native_client_sdk/src/libraries/nacl_io/path.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/path_test.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
binji
5 years, 9 months ago (2015-03-23 20:30:10 UTC) #1
Sam Clegg
Are other value allowed that are completely outside the range. (e.g. 99, 100) ? lgtm
5 years, 9 months ago (2015-03-23 20:32:34 UTC) #2
binji
On 2015/03/23 20:32:34, Sam Clegg wrote: > Are other value allowed that are completely outside ...
5 years, 9 months ago (2015-03-23 20:41:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018393007/40001
5 years, 9 months ago (2015-03-24 18:01:16 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-24 18:43:39 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 18:44:42 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/def60c001d10a9d70b7b8b4d8f8143a88bad81f5
Cr-Commit-Position: refs/heads/master@{#322035}

Powered by Google App Engine
This is Rietveld 408576698