Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java

Issue 1018393006: Add tracing to oknet (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/services/oknet/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
diff --git a/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java b/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
index 7fc249fab28b0fa12c48c674116bbc86c52b9a5a..c2fdd01b1cbc66ea928846fbbb5165a4b0cee02b 100644
--- a/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
+++ b/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
@@ -15,6 +15,7 @@ import com.squareup.okhttp.Request;
import com.squareup.okhttp.Response;
import com.squareup.okhttp.ResponseBody;
+import org.chromium.base.TraceEvent;
import org.chromium.mojo.system.AsyncWaiter;
import org.chromium.mojo.system.Core;
import org.chromium.mojo.system.DataPipe;
@@ -43,6 +44,8 @@ public class UrlLoaderImpl implements UrlLoader {
private OkHttpClient mClient;
private boolean mIsLoading;
private NetworkError mError;
+ private static long sNextTracingId = 1;
+ private final long mTracingId;
class CopyToPipeJob {
private BufferedSource mSource;
@@ -54,6 +57,7 @@ public class UrlLoaderImpl implements UrlLoader {
}
public void copy() throws IOException {
+ TraceEvent.begin("UrlLoaderImpl::CopyToPipeJob::copy");
int result = 0;
do {
try {
@@ -66,12 +70,15 @@ public class UrlLoaderImpl implements UrlLoader {
} catch (MojoException e) {
if (e.getMojoResult() != MojoResult.SHOULD_WAIT) throw e;
copyMoreAsync();
+ TraceEvent.end("UrlLoaderImpl::CopyToPipeJob::copy");
return;
}
} while (result != -1);
mIsLoading = false;
mProducer.close();
+ TraceEvent.finishAsync("UrlLoaderImpl", mTracingId);
+ TraceEvent.end("UrlLoaderImpl::CopyToPipeJob::copy");
}
private void copyMoreAsync() {
@@ -85,12 +92,14 @@ public class UrlLoaderImpl implements UrlLoader {
} catch (IOException e) {
mIsLoading = false;
mProducer.close();
+ TraceEvent.finishAsync("UrlLoaderImpl", mTracingId);
}
}
@Override
public void onError(MojoException exception) {
mIsLoading = false;
mProducer.close();
+ TraceEvent.finishAsync("UrlLoaderImpl", mTracingId);
}
});
}
@@ -102,6 +111,7 @@ public class UrlLoaderImpl implements UrlLoader {
mClient = client;
mIsLoading = false;
mError = null;
+ mTracingId = sNextTracingId++;
}
@Override
@@ -112,6 +122,7 @@ public class UrlLoaderImpl implements UrlLoader {
@Override
public void start(UrlRequest request, StartResponse callback) {
+ TraceEvent.startAsync("UrlLoaderImpl", mTracingId);
mIsLoading = true;
mError = null;
@@ -143,6 +154,7 @@ public class UrlLoaderImpl implements UrlLoader {
responseCallback.call(urlResponse);
mIsLoading = false;
+ TraceEvent.finishAsync("UrlLoaderImpl", mTracingId);
}
@Override
@@ -186,6 +198,7 @@ public class UrlLoaderImpl implements UrlLoader {
} catch (IOException e) {
mIsLoading = false;
producerHandle.close();
+ TraceEvent.finishAsync("UrlLoaderImpl", mTracingId);
}
}
});
« no previous file with comments | « sky/services/oknet/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698