[autofill] Ingore mouse move on Windows for the first 50ms.

chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/autofill_popup_base_view.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/ui/autofill/popup_constants.h"
 #include "ui/views/border.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/widget/widget.h"
 
+#if defined(OS_WIN)
+#include <mmsystem.h>

[Evan Stade, 2015/03/20 19:27:52]

ewww

can you use TimeTicks or something?

[please use gerrit instead, 2015/03/20 20:55:53]

event.time_stamp() is comparable to GetTickCount() and timeGetTime(), because it
uses the 32-bit timer provided by the Get­Tick­Count() function:

http://blogs.msdn.com/b/oldnewthing/archive/2014/01/22/10491576.aspx

timeGetTime() is pretty much the same thing as, but sometimes more accurate
than, GetTickCount():

http://blogs.msdn.com/b/larryosterman/archive/2009/09/02/what-s-the-differenc...

If you don't like the include, we can use Get­Tick­Count(), which is a Win32 API
function that's somehow magically available without an include.

I tried using base::TickCount as you suggested, but somehow it always lags by
~200 ms behind the event.time_stamp(). So we cannot use TimeTicks to compare to
event.time_stamp().

[spang, 2015/03/22 17:14:03]

Please don't put this kind of workaround here with out some kind of TODO or
comment.

If what you say is true, then there is a bug in the events implementation where
the timestamp can be populated from 1 of 2 clocks. Sometimes it is
base::TimeTicks(), and sometimes it is GetTickCount().

You cannot completely fix the issue by simply changing the choice of clock.

+#endif
+
 namespace autofill {
 
 const SkColor AutofillPopupBaseView::kBorderColor =
     SkColorSetARGB(0xFF, 0xC7, 0xCA, 0xCE);
 const SkColor AutofillPopupBaseView::kHoveredBackgroundColor =
     SkColorSetARGB(0xFF, 0xCD, 0xCD, 0xCD);
 const SkColor AutofillPopupBaseView::kItemTextColor =
     SkColorSetARGB(0xFF, 0x7F, 0x7F, 0x7F);
 const SkColor AutofillPopupBaseView::kPopupBackground =
     SkColorSetARGB(0xFF, 0xFF, 0xFF, 0xFF);
@@ skipping 34 matching lines @@
     // deletion.
     views::Widget* widget = new views::Widget;
     views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
     params.delegate = this;
     params.parent = container_view();
     widget->Init(params);
     widget->SetContentsView(this);
 
     // No animation for popup appearance (too distracting).
     widget->SetVisibilityAnimationTransition(views::Widget::ANIMATE_HIDE);
+
+#if defined(OS_WIN)
+    show_time_ = base::TimeDelta::FromMilliseconds(timeGetTime());
+#endif
   }
 
   SetBorder(views::Border::CreateSolidBorder(kPopupBorderThickness,
                                              kBorderColor));
 
   DoUpdateBoundsAndRedrawPopup();
   GetWidget()->Show();
 
   // Showing the widget can change native focus (which would result in an
   // immediate hiding of the popup). Only start observing after shown.
@@ skipping 57 matching lines @@
   // via AcceleratorPressed, so we need to let that run first.
   base::MessageLoop::current()->PostTask(
       FROM_HERE,
       base::Bind(&AutofillPopupBaseView::ClearSelection,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
 void AutofillPopupBaseView::OnMouseMoved(const ui::MouseEvent& event) {
   // A synthesized mouse move will be sent when the popup is first shown.
   // Don't preview a suggestion if the mouse happens to be hovering there.
+#if defined(OS_WIN)
+  if (event.time_stamp() - show_time_ <= base::TimeDelta::FromMilliseconds(50))
+    return;
+#else
   if (event.flags() & ui::EF_IS_SYNTHESIZED)
     return;
+#endif
 
   if (HitTestPoint(event.location()))
     SetSelection(event.location());
   else
     ClearSelection();
 }
 
 bool AutofillPopupBaseView::OnMousePressed(const ui::MouseEvent& event) {
   return event.GetClickCount() == 1;
 }
@@ skipping 68 matching lines @@
 void AutofillPopupBaseView::HideController() {
   if (delegate_)
     delegate_->Hide();
 }
 
 gfx::NativeView AutofillPopupBaseView::container_view() {
   return delegate_->container_view();
 }
 
 }  // namespace autofill