Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Unified Diff: content/renderer/accessibility/renderer_accessibility_browsertest.cc

Issue 1018383002: Make NavigationParams clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + addressed comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/renderer/navigation_state_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/accessibility/renderer_accessibility_browsertest.cc
diff --git a/content/renderer/accessibility/renderer_accessibility_browsertest.cc b/content/renderer/accessibility/renderer_accessibility_browsertest.cc
index 92d8dc05cc4482fc0705b2cace51bc51b7a05408..667294305a52c33c23ebc39decff6b28dbd7fa32 100644
--- a/content/renderer/accessibility/renderer_accessibility_browsertest.cc
+++ b/content/renderer/accessibility/renderer_accessibility_browsertest.cc
@@ -190,16 +190,15 @@ TEST_F(RendererAccessibilityTest,
// because the element it was referring to no longer exists,
// so the event here is from loading this new page.
CommonNavigationParams common_params;
- HistoryNavigationParams history_params;
+ RequestNavigationParams request_params;
common_params.url = GURL("data:text/html,<p>Hello, again.</p>");
common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
common_params.transition = ui::PAGE_TRANSITION_TYPED;
- history_params.current_history_list_length = 1;
- history_params.current_history_list_offset = 0;
- history_params.pending_history_list_offset = 1;
- history_params.page_id = -1;
- frame()->OnNavigate(common_params, StartNavigationParams(),
- CommitNavigationParams(), history_params);
+ request_params.current_history_list_length = 1;
+ request_params.current_history_list_offset = 0;
+ request_params.pending_history_list_offset = 1;
+ request_params.page_id = -1;
+ frame()->OnNavigate(common_params, StartNavigationParams(), request_params);
accessibility->SendPendingAccessibilityEvents();
EXPECT_TRUE(sink_->GetUniqueMessageMatching(
AccessibilityHostMsg_Events::ID));
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/renderer/navigation_state_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698