Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Unified Diff: content/common/frame_messages.h

Issue 1018383002: Make NavigationParams clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + addressed comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/common/navigation_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 38cd6baf033c0668cc77a0e587fdbcd611934b14..127daf0fb070ab93eed4e655aaea3d398e20f4fe 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -223,16 +223,22 @@ IPC_STRUCT_TRAITS_BEGIN(content::BeginNavigationParams)
IPC_STRUCT_TRAITS_MEMBER(has_user_gesture)
IPC_STRUCT_TRAITS_END()
-IPC_STRUCT_TRAITS_BEGIN(content::CommitNavigationParams)
+IPC_STRUCT_TRAITS_BEGIN(content::StartNavigationParams)
+ IPC_STRUCT_TRAITS_MEMBER(is_post)
+ IPC_STRUCT_TRAITS_MEMBER(extra_headers)
+ IPC_STRUCT_TRAITS_MEMBER(browser_initiated_post_data)
+ IPC_STRUCT_TRAITS_MEMBER(should_replace_current_entry)
+ IPC_STRUCT_TRAITS_MEMBER(transferred_request_child_id)
+ IPC_STRUCT_TRAITS_MEMBER(transferred_request_request_id)
+IPC_STRUCT_TRAITS_END()
+
+IPC_STRUCT_TRAITS_BEGIN(content::RequestNavigationParams)
IPC_STRUCT_TRAITS_MEMBER(is_overriding_user_agent)
IPC_STRUCT_TRAITS_MEMBER(browser_navigation_start)
IPC_STRUCT_TRAITS_MEMBER(redirects)
IPC_STRUCT_TRAITS_MEMBER(can_load_local_resources)
IPC_STRUCT_TRAITS_MEMBER(frame_to_navigate)
IPC_STRUCT_TRAITS_MEMBER(request_time)
-IPC_STRUCT_TRAITS_END()
-
-IPC_STRUCT_TRAITS_BEGIN(content::HistoryNavigationParams)
IPC_STRUCT_TRAITS_MEMBER(page_state)
IPC_STRUCT_TRAITS_MEMBER(page_id)
IPC_STRUCT_TRAITS_MEMBER(pending_history_list_offset)
@@ -241,15 +247,6 @@ IPC_STRUCT_TRAITS_BEGIN(content::HistoryNavigationParams)
IPC_STRUCT_TRAITS_MEMBER(should_clear_history_list)
IPC_STRUCT_TRAITS_END()
-IPC_STRUCT_TRAITS_BEGIN(content::StartNavigationParams)
- IPC_STRUCT_TRAITS_MEMBER(is_post)
- IPC_STRUCT_TRAITS_MEMBER(extra_headers)
- IPC_STRUCT_TRAITS_MEMBER(browser_initiated_post_data)
- IPC_STRUCT_TRAITS_MEMBER(should_replace_current_entry)
- IPC_STRUCT_TRAITS_MEMBER(transferred_request_child_id)
- IPC_STRUCT_TRAITS_MEMBER(transferred_request_request_id)
-IPC_STRUCT_TRAITS_END()
-
IPC_STRUCT_TRAITS_BEGIN(content::FrameReplicationState)
IPC_STRUCT_TRAITS_MEMBER(origin)
IPC_STRUCT_TRAITS_MEMBER(sandbox_flags)
@@ -363,11 +360,10 @@ IPC_MESSAGE_CONTROL4(FrameMsg_NewFrameProxy,
// Tells the renderer to perform the specified navigation, interrupting any
// existing navigation.
-IPC_MESSAGE_ROUTED4(FrameMsg_Navigate,
+IPC_MESSAGE_ROUTED3(FrameMsg_Navigate,
content::CommonNavigationParams, /* common_params */
content::StartNavigationParams, /* start_params */
- content::CommitNavigationParams, /* commit_params */
- content::HistoryNavigationParams /* history_params */)
+ content::RequestNavigationParams /* request_params */)
// Instructs the renderer to invoke the frame's beforeunload event handler.
// Expects the result to be returned via FrameHostMsg_BeforeUnload_ACK.
@@ -502,12 +498,11 @@ IPC_MESSAGE_ROUTED1(FrameMsg_SelectPopupMenuItem,
// Tells the renderer that a navigation is ready to commit. The renderer should
// request |stream_url| to get access to the stream containing the body of the
// response.
-IPC_MESSAGE_ROUTED5(FrameMsg_CommitNavigation,
+IPC_MESSAGE_ROUTED4(FrameMsg_CommitNavigation,
content::ResourceResponseHead, /* response */
GURL, /* stream_url */
content::CommonNavigationParams, /* common_params */
- content::CommitNavigationParams, /* commit_params */
- content::HistoryNavigationParams /* history_params */)
+ content::RequestNavigationParams /* request_params */)
#if defined(ENABLE_PLUGINS)
// Notifies the renderer of updates to the Plugin Power Saver origin whitelist.
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/common/navigation_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698