content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 1018383002: Make NavigationParams clearer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 1018383002: Make NavigationParams clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Charlie's comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index 76d530dcd940fda97f70c2c4beb57ff3c66f9064..caa210c45a37580aa1ccb0383575be19875acd8e 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -240,8 +240,8 @@ class NavigationControllerTest

const IPC::Message* message =

process()->sink().GetFirstMessageMatching(FrameMsg_Navigate::ID);

CHECK(message);

- Tuple<CommonNavigationParams, StartNavigationParams, CommitNavigationParams,

- HistoryNavigationParams> nav_params;

+ Tuple<CommonNavigationParams, StartNavigationParams,

+ RequestNavigationParams> nav_params;

FrameMsg_Navigate::Read(message, &nav_params);

return get<0>(nav_params).url;

}